feat(ui): debounce persistence instead of throttle #8410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Aug 11, 2025
psychedelicious
force-pushed
the
psyche/feat/ui/debounced-persistence
branch
from
3139642 to
89b1883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When server-backed client state persistence was introduced we also changed the persist strategy to be throttled instead of debounced. This causes some stutters while doing canvas operations that change state rapidly as we persist state. Reverted to debounced persistence at 2 seconds.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1149506274971631688/1403704300579983482
QA Instructions
It's possible that 2 seconds is too long. It means the app needs to be more or less idle for 2 seconds before you exit, else state isn't persisted. I think this is probably fine.
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)