Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onTokenRefresh typing #3460

Closed
wants to merge 7 commits into from
Closed

Fix onTokenRefresh typing #3460

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7d4530
Fix onTokenRefresh typing (related to #2889)
OrRosenblatt Apr 13, 2020
39af234
Fix Typescript validation
OrRosenblatt Apr 13, 2020
e948901
Merge branch 'master' into fix-ontokentefresh-typing
OrRosenblatt Apr 15, 2020
ed2bd36
Merge branch 'master' into fix-ontokentefresh-typing
OrRosenblatt Apr 21, 2020
a661587
Merge branch 'master' into fix-ontokentefresh-typing
OrRosenblatt May 4, 2020
dda8cd5
Disable TS linting error on using String type
OrRosenblatt May 4, 2020
9318bb1
Merge branch 'master' into fix-ontokentefresh-typing
OrRosenblatt May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Typescript validation
  • Loading branch information
@OrRosenblatt
OrRosenblatt committed Apr 13, 2020
commit 39af2347f075d649b1223034cdba04b8bec14cc3
2 changes: 1 addition & 1 deletion packages/messaging/lib/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ export namespace FirebaseMessagingTypes {
*
* @param listener Called with a FCM token when the token is refreshed.
*/
onTokenRefresh(listener: (token: String & { token: string}) => any) => () => void;
onTokenRefresh(listener: (token: String & { token: string }) => any): () => void;

/**
* On iOS, messaging permission must be requested by the current application before messages can
Expand Down