Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onTokenRefresh typing #3460

Closed

Conversation

OrRosenblatt
Copy link

Summary

The current type of onTokenRefresh listener isn't matching to the actual call type.
Related to #2889.

Checklist

  • Typescript types updated

Release Plan

[TYPES] [BUGFIX] [MESSAGING] - Update Typescript types for onTokenRefresh method in messaging


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #3460 into master will increase coverage by 50.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3460       +/-   ##
===========================================
+ Coverage   35.09%   85.25%   +50.16%     
===========================================
  Files          24      108       +84     
  Lines         761     3429     +2668     
  Branches      180        0      -180     
===========================================
+ Hits          267     2923     +2656     
- Misses        372      506      +134     
+ Partials      122        0      -122     

@OrRosenblatt OrRosenblatt changed the title Fix onTokenRefresh typing (related to #2889) Fix onTokenRefresh typing Apr 13, 2020
@Salakar Salakar added this to the v7.0.0 milestone Apr 14, 2020
@Salakar Salakar added blocked: do-not-merge Do not merge this issue without approval by the person who labelled this issue as Do Not Merge plugin: messaging FCM only - ( messaging() ) - do not use for Notifications labels Apr 14, 2020
@Salakar
Copy link
Contributor

Salakar commented May 5, 2020

Thanks for this PR, it has now been superseded by #3552 which has now been merged.

@Salakar Salakar closed this May 5, 2020
@OrRosenblatt OrRosenblatt deleted the fix-ontokentefresh-typing branch May 6, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: do-not-merge Do not merge this issue without approval by the person who labelled this issue as Do Not Merge plugin: messaging FCM only - ( messaging() ) - do not use for Notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants