Skip to content

Fix Unicode encoding of Git commands from web UI #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

isc-pbarton
Copy link
Collaborator

Fixes #627

CHANGELOG.md Outdated
@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.8.0] - Unreleased
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update module.xml as well, and should be 2.7.1 for now in case we do a bug fix release

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 25.77%. Comparing base (659a268) to head (a97f823).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cls/SourceControl/Git/WebUIDriver.cls 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   25.81%   25.77%   -0.04%     
==========================================
  Files          21       21              
  Lines        2801     2805       +4     
==========================================
  Hits          723      723              
- Misses       2078     2082       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isc-tleavitt isc-tleavitt merged commit 2db11a5 into main Nov 8, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the commit-encoding branch November 8, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

International characters in commit messages improperly encoded
3 participants