-
Notifications
You must be signed in to change notification settings - Fork 9
Compact sidebar #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact sidebar #537
Conversation
Compacted the sidebar; Fixed alignment of icons
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 18 18
Lines 2608 2608
=======================================
Hits 665 665
Misses 1943 1943 ☔ View full report in Codecov by Sentry. |
@isc-tleavitt Let me know if we need further compacting / other UI changes to the sidebar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isc-etamarch this is a vast improvement, thank you.
My main remaining concern is the behavior with highly limited vertical space - there might not be enough for the remote branch view. This is great:
But this is not - from in VSCode (which is particularly egregiously bad for some reason - maybe there are other steps we could take re: zoom/etc. to make this better):
Note the overlap of "Remote Branches" with the links underneath, and the fact that you cant see "More..."
I don't want to go too crazy on this, but let's try to make it a bit better first.
Added margins to the bottom navigation so that the remote branches would not be visible underneath. Also added padding below remote branches to that they can all be visible with scrolling
Fixes #525