Skip to content

Compact sidebar #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Compact sidebar #537

merged 6 commits into from
Oct 21, 2024

Conversation

isc-etamarch
Copy link
Collaborator

Fixes #525

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.49%. Comparing base (a642f94) to head (668302f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   25.49%   25.49%           
=======================================
  Files          18       18           
  Lines        2608     2608           
=======================================
  Hits          665      665           
  Misses       1943     1943           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isc-etamarch
Copy link
Collaborator Author

@isc-tleavitt Let me know if we need further compacting / other UI changes to the sidebar

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isc-etamarch this is a vast improvement, thank you.

My main remaining concern is the behavior with highly limited vertical space - there might not be enough for the remote branch view. This is great:
image

But this is not - from in VSCode (which is particularly egregiously bad for some reason - maybe there are other steps we could take re: zoom/etc. to make this better):
image

Note the overlap of "Remote Branches" with the links underneath, and the fact that you cant see "More..."

I don't want to go too crazy on this, but let's try to make it a bit better first.

isc-tleavitt and others added 3 commits October 15, 2024 19:20
Added margins to the bottom navigation so that the remote branches would not be visible underneath. Also added padding below remote branches to that they can all be visible with scrolling
@isc-tleavitt isc-tleavitt merged commit ba7fd7c into main Oct 21, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the issue-525 branch October 21, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit left-side navigation spacing in WebUI for usability on smaller monitors
3 participants