Repository navigation
feat(assembly): save one calendar date on the assembly host (#5358) - #5373
Merged
Merged
Conversation
Active Assembly writes one yyyy-MM-dd date through the item field save. A blank date, Cancel, a read-only date, and HTTP 400/403/409 do not claim success. Fixes #5358 > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
Machine gate approves. Preexisting complexity suggestions only. LLM stage hit a CUDA out-of-memory warning and did not block. > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
This was referenced Oct 8, 2026
> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Independent Erlang review of 6788566: 0 blocking bugs. May merge: yes. Preexisting cognitive complexity only. Ollama CUDA OOM is not a product defect. Full report is in this PR body and docs/ai-generated/code-reviews/pr-5373-erlang.md.
|
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Active Assembly saves one calendar date (
yyyy-MM-dd) on the assembled page through the existing item field PUT (dataTypedate). Reload shows that date. Other fields are left as they were. A blank date does not clear a stored date. Cancel, a read-only date, and HTTP 400, 403, and 409 do not claim success. Datetime, clear, and the Content Editor host stay out of scope.Parent: #4530. Slice 104.
Fixes #5358
Operator: Grok: night-issue-prs (model grok-4.7)
Test plan
dataTypedatefield (not datetime) and other text fields.Checklist
product-docs/8.2/admin/content-explorer.md(Active Assembly section only)clean installgreenmodules/perc-qa-automation/frontend/tests/assembly-date-field.spec.js(7 passed on H2 QA)final/API-shape changeBuild evidence
modules_built:
WebUI,modules/perc-qa-automationdownstream_checked: none (no Java type made final/sealed and no public signature change)
cd WebUI && rtk mvn clean install— BUILD SUCCESS. SurefireTests run: 69, Failures: 0, Errors: 0, Skipped: 0. VitestTest Files 727 passed,Tests 6916 passed. No new warnings from this change (preexisting javadoc and dependency warnings only).cd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS.No tests to run(Playwright is the surface run below).UI proof (H2 QA)
python3 docker/scripts/perc-devctl.py qa-up— RESULT:OK.TEST_CMS_URL=http://127.0.0.1:9993QA_CMS_HOST_PORT=9993containerperc-matrix-cms-h2.python3 docker/scripts/perc-devctl.py qa-health— RESULT:OK HTTP:200 HEALTH:healthy.WebUI/target/generated-webui/cm/modern/assetsinto/opt/Percussion/jetty/base/webapps/Rhythmyx/cm/modern/assets(static SPA; no Jetty restart; nodocker restart).qa-healthagain — RESULT:OK HEALTH:healthy.cd modules/perc-qa-automation/frontend && TEST_CMS_URL=http://127.0.0.1:9993 ADMIN_USERNAME=Admin TEST_DB_TYPE=h2 TEST_PRODUCT=cms npm run test:surface -- --path tests/assembly-date-field.spec.js— 7 passed.assertQuiet; no serious page errors).server.logfor the cell).python3 docker/scripts/perc-devctl.py qa-down— container removed.Pre-push local code review
Independent Erlang review (not the author). Full report: