Repository navigation
feat(publishing): set one modern content list generator - #5290
Merged
Merged
Conversation
Publishing design saves the generator alone on a modern content list. Name, description, type, and item filter stay stored, and a legacy list URL is not changed. A blank or overlong generator does not write. Fixes #5269 > Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
Erlang review LGTM. Same-login APPROVE is rejected by GitHub, so this comment is the review. mkd-code-review 0.1.18, persona erlang 0.1.1, base origin/main, head b241f4c. Machine gate: 0 blocking bugs. Preexisting cognitive complexity on applyContentListFields is not an in-diff bug. Ollama dev-coder HTTP 500 (CUDA OOM) is not a gate. Full report is in the PR body and docs/ai-generated/code-reviews/pr-5290-erlang.md.
|
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishing design can set the generator on one modern content list without changing the name, description, type, or item filter. Generator sends the existing content-list update with only
generator. A legacy row has no generator action, so a legacy URL is not changed. Cancel does not write. A blank or overlong generator does not write. HTTP 400, 403, and 409 leave the previous generator in place.Parent: #4531. Slice: #5269.
Operator: Grok: night-issue-prs (model grok-4.6)
Fixes #5269
Test plan
spa.jsp?entry=publish§ion=design).tests/publishing/designContentListGenerator.spec.js(3 passed).Checklist
product-docs/8.2/admin/publishing.md(Set a content list generator)PSPublishingDesignRestServiceTestgenerator cases; WebUI VitestcontentListGenerator.test.tsandDesignSection.contentListGenerator.test.tsxmodules/perc-qa-automation/frontend/tests/publishing/designContentListGenerator.spec.jsprojects/sitemanageandWebUI(no skipTests). No public signature change, so no reverse-dep compile.Build evidence
modules_built: projects/sitemanage, WebUI, modules/perc-qa-automation
downstream_checked: none (no final/sealed type and no public or protected signature change)
cd projects/sitemanage && rtk mvn clean install— BUILD SUCCESS. Tests run: 3644, Failures: 0, Errors: 0, Skipped: 125cd WebUI && rtk mvn clean install— BUILD SUCCESS. Java tests run: 69, Failures: 0. Vitest: Test Files 704 passed, Tests 6491 passedcd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS. No Java tests (Playwright is the surface run below)UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up --skip-image-build --then-qa-deploy-webui— RESULT:OK. TEST_CMS_URL=http://127.0.0.1:9993. Deployed generatedcm/modernand WAR jars (perc-system,rest,sitemanage,extensions-workflow) with in-cell Jetty restart.python3 docker/scripts/perc-devctl.py qa-healthafter that restart — RESULT:OK HTTP:200 HEALTH:healthycd modules/perc-qa-automation/frontend && TEST_CMS_URL=http://127.0.0.1:9993 ADMIN_USERNAME=Admin TEST_DB_TYPE=h2 TEST_PRODUCT=cms npm run test:surface -- --path tests/publishing/designContentListGenerator.spec.js— 3 passedpython3 docker/scripts/perc-devctl.py qa-down— RESULT:OKPre-push local code review
Independent Erlang review (persona erlang 0.1.1). Full
mkd-code-review analyzereport: