Repository navigation
feat(publishing): set a publishing context description - #5263
Merged
Merged
Conversation
Design saves or clears one context description without changing the name or location schemes. Overlong text is rejected before anything is written. Fixes #5250 > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
Record the independent mkd-code-review advisory report. > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Erlang (independent, mkd-code-review 0.1.18, persona erlang 0.1.1, gate advisory) found no in-diff blocking bugs. GitHub rejected a same-login APPROVE, so this comment records the review. Required checks were still running on the review-doc commit when this was posted.
|
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishing Design can set or clear the description of one publishing context. Save description sends the existing
PUT …/sitemanage/publishingdesign/contexts/{contextId}with acontextobject that contains only the description, so the name and default scheme stay stored and location schemes are not moved. A blank description clears the stored text. A description longer than 255 characters (RXCONTEXT.CONTEXTDESC) is rejected before any field is written.Parent: #4531. Fixes #5250.
Operator: Grok: night-issue-prs (model grok-4.7)
Test plan
Checklist
product-docs/8.2/admin/publishing.md(Set a publishing context description)modules/perc-qa-automation/frontend/tests/publishing/designContextDescription.spec.js(2 passed on H2)projects/sitemanageandWebUIBuild evidence
modules_built: projects/sitemanage, WebUI
downstream_checked: none (no public signature, final, or sealed type change)
cd projects/sitemanage && rtk mvn clean install— BUILD SUCCESS. Tests run: 3615, Failures: 0, Errors: 0, Skipped: 125cd WebUI && rtk mvn clean install— BUILD SUCCESS. Vitest: Test Files 698 passed, Tests 6416 passed. Java Tests run: 69, Failures: 0JAVA_HOME=/usr/lib/jvm/java-21-openjdk)UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up --skip-image-build— RESULT:OK. TEST_CMS_URL=http://127.0.0.1:9993 QA_CMS_HOST_PORT=9993 container perc-matrix-cms-h2python3 docker/scripts/perc-devctl.py qa-deploy-webui— RESULT:OKpython3 docker/scripts/perc-devctl.py qa-deploy-war-jars --restart-jetty— RESULT:OK (sitemanage plus perc-system/rest/extensions-workflow into the Rhythmyx WAR; in-cell Jetty restart, not docker restart)python3 docker/scripts/perc-devctl.py qa-health— RESULT:OK HTTP:200 HEALTH:healthycd modules/perc-qa-automation/frontend && rtk npm run test:surface -- --path tests/publishing/designContextDescription.spec.jswith TEST_CMS_URL, ADMIN_USERNAME=Admin, TEST_DB_TYPE=h2, TEST_PRODUCT=cms — 2 passedPre-push local code review
Summary
Machine analysis found 1 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
Issue 1 -- Severity: suggestion
complexity.cognitivearborist-metricsupdateContextcognitive=17 (max 15), cyclomatic=13 (max 15)Independent diff read: a description-only update leaves the name, default scheme, and location schemes; blank clears; overlong text is rejected before any field write. The updateContext cognitive complexity suggestion is not a defect.
Durable copy:
docs/ai-generated/code-reviews/pr-5263-erlang.md.