Repository navigation
feat(publish): rename a delivery type by name only - #5214
Merged
Merged
Conversation
PublishingShell Design renames one delivery type through the existing update. The request sends only the name, so the bean name, description, and unpublishing flag stay stored. The list shows the new name after save; a blank name, cancel, and HTTP 400, 403, and 409 keep the old name. Fixes #5203 > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
Independent mkd-code-review 0.1.18 (erlang 0.1.1, pack percussion, advisory, origin/main). In-diff bugs: 0. > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
Erlang LGTM. Independent review of PR #5214 (not the author). mkd-code-review 0.1.18, erlang 0.1.1, pack percussion, advisory, base origin/main. Persona source: ~/.local/share/mkd/agents/erlang. In-diff bugs: 0. May commit/push: yes.
|
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent: #4531. Slice #5203.
PublishingShell Design can rename one delivery type. Rename sends
PUT …/publishingdesign/deliverytypes/{deliveryTypeId}with adeliveryTypeobject that contains only the new name. Bean name, description, and whether unpublishing requires assembly are omitted, so the server leaves them stored. The list keeps the previous name until that update succeeds, then shows the new name and the same bean name. A blank or over-long name is rejected in the form. Cancel and HTTP 400, 403, and 409 do not change the list.Fixes #5203
Operator: Grok: night-issue-prs (model grok-4.7)
Test plan
Checklist
product-docs/8.2/admin/publishing.md(Rename a delivery type)modules/perc-qa-automation/frontend/tests/publishing/designDeliveryTypeRename.spec.jsprojects/sitemanage,WebUI, andmodules/perc-qa-automationBuild evidence
modules_built: projects/sitemanage, WebUI, modules/perc-qa-automation
downstream_checked: no signature change on
updateDeliveryType. AddedPSDeliveryTypeSummary.isUnpublishingRequiresAssemblySpecified()(XmlTransient, not on the wire). Grep showsPSDeliveryTypeSummaryis used only in sitemanage. RestoredrestSNAPSHOT from this worktree before the sitemanage build because~/.m2had a newer sibling snapshot (updateTransitionApprovalsRequired) that is not onmain. That rest install used-DskipTestsand is not a changed module.cd projects/sitemanage && rtk mvn clean install— BUILD SUCCESS. Tests run: 3540, Failures: 0, Errors: 0, Skipped: 125cd WebUI && rtk mvn clean install— BUILD SUCCESS. Java tests run: 69, Failures: 0. Vitest: Test Files 677 passed, Tests 6179 passedcd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS. No Java tests (Playwright spec is the C5 surface run)JAVA_HOME:
/usr/lib/jvm/java-21-openjdk. No new compiler warnings on the changed types.UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up --skip-image-build --then-qa-deploy-webuipython3 docker/scripts/perc-devctl.py qa-health— RESULT:OK STEP:qa-health HTTP:200 HEALTH:healthycd modules/perc-qa-automation/frontend && rtk npm run test:surface -- --path tests/publishing/designDeliveryTypeRename.spec.jsPre-push local code review
Erlang (independent of the author): approve. In-diff bugs: 0.
DeliveryTypesPanelcomplexity is preexisting and does not block. Name-only PUT leaves bean, description, and the omitted assembly flag stored. No blocking defect.