Repository navigation
feat(publish): delete one location scheme from Design (#5134) - #5144
Merged
Merged
Conversation
Confirm deletes a context location scheme only after DELETE succeeds. Cancel does not call the server. HTTP 400, 403, and 409 stay in the Design error region and leave the row in place. > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
This was referenced Oct 4, 2026
> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
Erlang 0.1.1 independent review (mkd-code-review 0.1.18, pack percussion, gate advisory). Location-scheme delete removes the row only after DELETE succeeds. Cancel does not call the server. HTTP 400/403/409 stay in the contexts error and leave the row. Blocking bugs: 0. Recommendation: approve. Report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent: #4531. Slice #5134.
PublishingShell Design Contexts / schemes confirms, then reuses
deleteScheme(DELETE /services/sitemanage/publishingdesign/schemes/{schemeId}). The location-scheme row leaves that context only after DELETE succeeds. If the list refresh fails after success, that row is still dropped and other schemes stay. Cancel does not call the server. HTTP 400, 403, and 409 stay in the contexts error region and do not claim the scheme was deleted. ApiError is not anError, so the old handler showed only a generic message.This is not scheme save (#4702), scheme copy (#5109), content-list delete, context delete, or edition delete (#5083).
Operator: Grok: night-issue-prs (model grok-4.7)
Fixes #5134
Test plan
TEST_CMS_URLfromperc-devctl qa-up). Log in as Admin. Open Publish → Design → Contexts / schemes.Checklist
product-docs/8.2/admin/publishing.md(Delete a location scheme)clean installgreenmodules/perc-qa-automation/frontend/tests/publishing/designLocationSchemeDelete.spec.js(3 passed on H2) plus golden smoke (2 passed)rtk mvn clean installforWebUIandmodules/perc-qa-automation(no skipTests)Build evidence
modules_built: WebUI, modules/perc-qa-automation
downstream_checked: none (no
final/sealedtype, no public/protected signature change, no package API used by other modules)npm engine and Vite chunk-size warnings, and the existing WebUI javadoc warnings, match the module baseline. No new warnings from this change.
UI proof (C5)
The first surface run failed in scheme create: the skip-image-build cell's
perc-systemstack-overflowed infindSchemesByContextId(interface default ↔ impl). Current main already overrides that method with the query. Hot-deployed matching SNAPSHOT jars and restarted Jetty inside the cell (no docker restart):Pre-push local code review
Independent Erlang pass (not the author). Manual read of
ContextsPanel.removeSchemeandlocationSchemeDelete.ts: the row is replaced only after DELETE succeeds; Cancel onwindow.confirmreturns before the call; HTTP 400/403/409 set the contexts error and leave the previous rows. No blocking bug. Non-blocking: the 409 fallback string is hardcoded English. LLM CUDA OOM is not a defect.Summary
Machine analysis found 1 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
Issue 1 -- Severity: suggestion
File: review
Rule:
llm.errorTool:
llmDescription: model
ollama-dev-coderfailed: http: status 500 Internal Server Error body {"error":{"message":"llama-server process has terminated: exit status 1: cudaMalloc failed: out of memory\nalloc_tensor_range: failed to allocate CUDA0 buffer of size 5064192000\nerror loading model: unable to allocate CUDA0 buffer","type":"api_error","param":null,"code":null}}Status: open