Repository navigation
fix: PublishingShell item takedown HTTP status mapping (#4742) - #4755
Merged
Merged
Conversation
Site-workspace Remove From Site already unpublishes without deleting the item. Map those HTTP statuses to panel errors (not success) and cover them in vitest and Playwright. > Co-Authored by Grok Build 1.0.40 using grok-4.6 with agent night-issue-prs.
This was referenced Sep 23, 2026
Record the pre-push mkd-code-review report for publishing item takedown. > Co-Authored by Grok Build 1.0.40 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Independent Erlang review (mkd-code-review 0.1.18, persona erlang 0.1.1, gate advisory). No in-diff bugs. GitHub rejected same-login APPROVE; this comment is the LGTM. Full CLI report is in the PR body under Pre-push local code review and in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent: #4531. Slice #4742.
Publishing site-workspace Remove From Site already unpublishes a page or asset (it does not delete the CMS content item). This change maps HTTP 400, 403, 404, and 409 on that panel to operator errors instead of success, and documents that behavior.
Operator: Grok: night-issue-prs (model grok-4.6)
Test plan
ItemTakedownPanelandtakedownSelectedItem(takedown URL, not delete)tests/publishing/itemTakedown.spec.json H2 QA (3 passed), including 400/403/404/409Product documentation
product-docs/8.2/admin/publishing.md(take down does not delete the item; HTTP 400/403/404/409)Maven / C3
cd WebUI && rtk mvn clean install— BUILD SUCCESS. Java Tests run: 69, Failures: 0. Vitest: Test Files 519 passed, Tests 4808 passed.cd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS. No tests to run (Playwright is opt-in).C5 UI proof
python3 docker/scripts/perc-devctl.py qa-up— TEST_CMS_URL=http://127.0.0.1:9993 (freeport; do not hardcode)qa-healthRESULT:OK HEALTH:healthyqa-deploy-webuithenqa-healthagain RESULT:OKnpm run test:surface -- --path tests/publishing/itemTakedown.spec.js— 3 passedqa-downRESULT:OKFixes #4742
Pre-push local code review
Erlang review — PR #4755
Scope
CLI stdout (
mkd-code-review analyze --format markdown)Summary
Machine analysis found 0 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
No issues.