Repository navigation
feat(perc-packages): residual product widget XML compiler batch + goldens (#2789) - #2803
Merged
Merged
Conversation
…dens (#2789) Extend Widget XML package compiler with RESIDUAL_PRODUCT_PACKAGE_DIRS for blog/calendar/directory/social/form/poll/login/rss/iframe (13 widgets). Add golden parity for percForm, percPoll, percIframe; keep dual-run product XML. Refs parent #2630 (Phase 3) and prior batches #2751 #2772. > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
natechadwick
enabled auto-merge (squash)
August 10, 2026 19:44
natechadwick
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent epic #2630 (Phase 3 product Widget XML → package model). Continues after baseWidgets (#2751) and high-traffic (#2772 / cluster #2791).
Adds a PR-sized residual long-tail batch of product Widget XML packages to the modern compiler path with golden parity, without removing product Widget XML (dual-run).
Batch (#2789) — 9 packages / 13 widgets
perc.widgets.blogperc.widget.calendarperc.widget.directoryperc.widget.socialButtonsperc.widget.formperc.widget.pollperc.widget.loginperc.widget.rssperc.widget.iframeGoldens
percForm(integration + CT)percPoll(social + CT + UserPrefs)percIframe(chrome / no CT)Code
RESIDUAL_PRODUCT_PACKAGE_DIRS+compileResidualProductPackages/ sharedcompileNamedPackagesFixes #2789
Partial of #2630 (further residual #2802)
Operator: Grok: night-issue-prs (model grok-4.5)
Test plan
cd modules/perc-packages && ../../mvnw.cmd clean installPSWidgetXmlCompilerTestresidual suite green (package compile 13 widgets + 3 goldens)rxconfig/Widgets/*.xmlstill present (dual-run)C3 build evidence
modules/perc-packagescd modules/perc-packages; ../../mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 68, Failures: 0 (widgetxml tests: 24)