Repository navigation
fix(perc-content-explorer): DCE cataloger this-escape real fix (#2547) - #2610
Merged
Merged
Conversation
Clear javac this-escape on six Desktop Content Explorer catalogers without @SuppressWarnings: final classes, final collection/map fields, static nested Role/Subject, private applyFromXml helpers, and package-private pure static parse helpers used by URL constructors and fromXml. Keeps prior typed collections. Extends PSCatalogerTypingTest for parse helpers + clone. Parent: #2045 / monorepo #2200. Fixes #2547. > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
This was referenced Aug 9, 2026
natechadwick
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Real-fix residual this-escape on six Desktop Content Explorer catalogers under parent #2045 / monorepo #2200 (issue #2547). Not suppress-only.
Catalogers
PSCommunityCatalogerPSRoleCatalogerPSSubjectCatalogerPSLocaleCatalogerPSGlobalTemplateCatalogerPSCommunityContentTypeMapperCatalogerApproach
finalfinal(contents replaced via clear/addAll or putAll)fromXmlduring construction)Role/Subjectmadestatic final(no outer-instance capture)applyFromXmlhelpers from Element constructorsCollection/IteratorAPIs kept intactTest plan
cd modules/DesktopContentExplorer && ../../mvnw clean install— BUILD SUCCESSPSCatalogerTypingTest— Tests run: 13, Failures: 0 (includes pure parse helpers + clone)this-escapeon these files)Gates evidence
-am)Links