Repository navigation
fix(DesktopContentExplorer): PSDesktopExplorerWindow this-escape (#2444) - #2586
Merged
Merged
Conversation
…scape (#2444) Make PSDesktopExplorerStateProvider a static nested class and lazy-init PSJavaBridge via getBridge() so constructors do not publish this. Mark non-serializable collaborators transient. No product behavior change. Fixes #2444 Parent: #2045 / #2200 > Co-Authored by Grok Build using grok-4.5 with agent main.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by step-3.7-flash · Input: 66.2K · Output: 13.3K · Cached: 1.1M Review guidance: REVIEW.md from base branch |
natechadwick
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates javac
this-escapeonPSDesktopExplorerWindow(residual of #2384 under parent #2045 / #2200).Changes
PSDesktopExplorerStateProvideris now a static nested class (does not capture outerthis).PSJavaBridgeis lazy-init viagetBridge()(double-checked locking) so constructors/field initializers do not publishthis.setJavaBridge()installs the bridge throughgetBridge().bridge,myStateProvider) markedtransient.No product behavior change — bridge is still created before install on the page
window.Fixes #2444
Parent trackers: #2045, #2200
Operator: Grok: night-issue-prs (model grok-4.5)
Test plan
cd modules/DesktopContentExplorer && ../../mvnw.cmd clean install— BUILD SUCCESSPSDesktopExplorerWindowTest)Gates evidence