Skip to content

fix(perc-content-explorer): type relationships manager + process monitor (#2446) - #2544

Merged
natechadwick merged 1 commit into
mainfrom
fix/issue-2446-dce-relationships-process-monitor
Aug 9, 2026
Merged

natechadwick merged 1 commit into
mainfrom
fix/issue-2446-dce-relationships-process-monitor

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

Residual -Xlint batch under parent #2045 / monorepo #2200 (residual of #2384, issue #2446): type collections/iterators on PSItemRelationshipsManager and pure helpers on PSProcessMonitor.

  • PSItemRelationshipsManager.loadDependencies returns Iterator<PSNode>
  • Typed Iterator<PSComponentSummary> over summaries (no raw casts)
  • Pure helpers: formatDependencyLabel, isAllowedRelationshipSlot, filterSummariesByContentIds
  • PSProcessMonitor: isValidTotal / isValidStatus / computePercentDone pure helpers
  • PSActionManager DT view: drop asNodes cast bridge at loadDependencies call site
  • Tests: PSItemRelationshipsManagerTest (6), PSProcessMonitorTest (4)
  • Erlang: docs/ai-generated/code-reviews/issue-2446-dce-relationships-process-monitor-erlang.md

Fixes #2446. Parent tracker: #2045.

Module remains hot (pre-existing residuals #2444, #2445, #2439 + further ActionManager/Wizard/cataloger this-escape).

Test plan

  • cd modules/DesktopContentExplorer && ../../mvnw.cmd clean install — BUILD SUCCESS
  • Tests run: 64, Failures: 0 (includes 10 new pure-helper tests)
  • No new warnings on named files PSItemRelationshipsManager / PSProcessMonitor

Gates

  • Erlang self-review: pass
  • Per-module clean install: perc-content-explorer standalone
  • No product behavior change intended

Operator: Grok: night-issue-prs (model grok-4.5)

Fixes #2446

Co-Authored by Grok Build using grok-4.5 with agent main.

…tor (#2446)

Type Iterator/collections on PSItemRelationshipsManager, pure helpers + tests
for label/slot/summary filtering and PSProcessMonitor status/percent helpers.
PSActionManager DT loadDependencies call site uses typed Iterator<PSNode>.

Parent #2045 residual of #2384.

> Co-Authored by Grok Build using grok-4.5 with agent main.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

Module residual follow-ups (parent #2045, p8): #2545 #2546 #2547. Existing open: #2444 #2445 #2439.

Co-Authored by Grok Build using grok-4.5 with agent main.

@kilo-code-bot

kilo-code-bot Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • docs/ai-generated/code-reviews/issue-2446-dce-relationships-process-monitor-erlang.md
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSActionManager.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSItemRelationshipsManager.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSProcessMonitor.java
  • modules/DesktopContentExplorer/src/test/java/com/percussion/cx/PSItemRelationshipsManagerTest.java
  • modules/DesktopContentExplorer/src/test/java/com/percussion/cx/PSProcessMonitorTest.java

Reviewed by step-3.7-flash · Input: 80.2K · Output: 15.4K · Cached: 1.2M

Review guidance: REVIEW.md from base branch main

@natechadwick
natechadwick merged commit 1fa26fa into main Aug 9, 2026
6 checks passed
@natechadwick
natechadwick deleted the fix/issue-2446-dce-relationships-process-monitor branch August 9, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.5 Grok 4.5 model operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[8.2] perc-content-explorer: PSItemRelationshipsManager + PSProcessMonitor residual (#2045)

2 participants