Skip to content

fix(perc-content-explorer): clear PSFolderDialog residual Xlint (#2441) - #2509

Merged
natechadwick merged 1 commit into
mainfrom
fix/issue-2441-psfolderdialog-xlint
Aug 8, 2026
Merged

natechadwick merged 1 commit into
mainfrom
fix/issue-2441-psfolderdialog-xlint

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

Clears the 5 residual -Xlint diagnostics on PSFolderDialog left after the #2380 panel rawtypes PR (#2438).

Diagnostic Fix
this-escape Class made final (no subclasses); early setResizable(true) removed — still applied in initDialog() after full field init
serial (×4 non-serializable collaborators) m_parentFolderNode, m_folderNode, m_folderMgr, m_userInfo marked transient; m_applet also transient
serialVersionUID Already present

No product behavior change. Prefer real fixes over class-level suppress. Structural tests in PSFolderDialogTest.

Parent / links

Test plan

  • Erlang self-review approve — docs/ai-generated/code-reviews/issue-2441-psfolderdialog-xlint-erlang.md
  • Standalone module clean install:
    cd modules/DesktopContentExplorer ../../mvnw.cmd clean install
    BUILD SUCCESS — Tests run: 54, Failures: 0 (includes PSFolderDialogTest ×3)
  • Direct javac -Xmaxwarns 5000 on PSFolderDialog.java: 5 → 0 warnings
  • No new warnings attributable to this change (baseline shade/dependency-analyze only)

Gates

  • Pre-PR Maven verification: standalone perc-content-explorer clean install green
  • Cross-platform paths: N/A (no path/file I/O)
  • Operator: Grok: night-issue-prs (model grok-4.5)

Co-Authored by Grok Build using grok-4.5 with agent main.

Make PSFolderDialog final and mark non-serializable session collaborators
transient; drop early setResizable so initDialog owns UI finalize. Zero
remaining this-escape/serial diags under -Xmaxwarns. Structural unit tests
added. No product behavior change. Residual of #2380; parents #2045 #2200.

> Co-Authored by Grok Build using grok-4.5 with agent main.
@kilo-code-bot

kilo-code-bot Bot commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • docs/ai-generated/code-reviews/issue-2441-psfolderdialog-xlint-erlang.md
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSFolderDialog.java
  • modules/DesktopContentExplorer/src/test/java/com/percussion/cx/PSFolderDialogTest.java

Reviewed by step-3.7-flash · Input: 49.8K · Output: 6.4K · Cached: 369K

Review guidance: REVIEW.md from base branch main

@natechadwick
natechadwick merged commit 1f96334 into main Aug 8, 2026
6 checks passed
@natechadwick
natechadwick deleted the fix/issue-2441-psfolderdialog-xlint branch August 8, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.5 Grok 4.5 model operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[8.2] perc-content-explorer: PSFolderDialog residual warnings (#2380/#2045)

2 participants