Repository navigation
fix(perc-content-explorer): clear PSFolderDialog residual Xlint (#2441) - #2509
Merged
Merged
Conversation
Make PSFolderDialog final and mark non-serializable session collaborators transient; drop early setResizable so initDialog owns UI finalize. Zero remaining this-escape/serial diags under -Xmaxwarns. Structural unit tests added. No product behavior change. Residual of #2380; parents #2045 #2200. > Co-Authored by Grok Build using grok-4.5 with agent main.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by step-3.7-flash · Input: 49.8K · Output: 6.4K · Cached: 369K Review guidance: REVIEW.md from base branch |
natechadwick
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the 5 residual
-Xlintdiagnostics onPSFolderDialogleft after the #2380 panel rawtypes PR (#2438).this-escapefinal(no subclasses); earlysetResizable(true)removed — still applied ininitDialog()after full field initserial(×4 non-serializable collaborators)m_parentFolderNode,m_folderNode,m_folderMgr,m_userInfomarkedtransient;m_appletalso transientserialVersionUIDNo product behavior change. Prefer real fixes over class-level suppress. Structural tests in
PSFolderDialogTest.Parent / links
PSFolderAclEditorDialog([8.2] perc-content-explorer: PSFolderAclEditorDialog rawtypes residual (#2380/#2045) #2439)Test plan
docs/ai-generated/code-reviews/issue-2441-psfolderdialog-xlint-erlang.mdcd modules/DesktopContentExplorer ../../mvnw.cmd clean installBUILD SUCCESS — Tests run: 54, Failures: 0 (includes
PSFolderDialogTest×3)javac -Xmaxwarns 5000onPSFolderDialog.java: 5 → 0 warningsGates
perc-content-explorerclean install green