Skip to content

fix(perc-content-explorer): cataloger Collection/Iterator typing (#2384) - #2447

Merged
natechadwick merged 1 commit into
mainfrom
fix/issue-2384-cataloger-typing
Aug 8, 2026
Merged

natechadwick merged 1 commit into
mainfrom
fix/issue-2384-cataloger-typing

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

Residual javac -Xlint batch for perc-content-explorer under #2045 / #2200 (issue #2384): clear cataloger Collection/Iterator rawtypes and type PSDisplayFormatCatalog.

  • Real generics on PSCommunityCataloger, PSRoleCataloger, PSSubjectCataloger, PSSiteCataloger, PSLocaleCataloger, PSGlobalTemplateCataloger, PSCommunityContentTypeMapperCataloger
  • PSDisplayFormatCatalog: List/Iterator<PSDisplayFormat>
  • Call sites: folder general/ACL editor, copy-site wizard pages, PSFolderActionManager (Set<Integer> getFolderCommunities, site loop), search view display formats
  • PSDesktopExplorerWindow: serialVersionUID only (this-escape residual [8.2] perc-content-explorer: PSDesktopExplorerWindow this-escape residual (#2045) #2444)
  • Tests: PSCatalogerTypingTest (6), PSDisplayFormatCatalogTest (1)
  • Erlang: docs/ai-generated/code-reviews/issue-2384-cataloger-typing-erlang.md

Partial for #2384. Also closes cataloger slice #2440 (duplicate inventory of this batch).

Residual filed

Test plan

  • cd modules/DesktopContentExplorer && ../../mvnw.cmd clean install — BUILD SUCCESS
  • Tests run: 43, Failures: 0 (includes 7 new)

Gates

  • Erlang self-review: pass
  • Per-module clean install: perc-content-explorer
  • No product behavior change intended

Operator: Grok: night-issue-prs (model grok-4.5)

Partial for #2384 (cataloger + display format + serialVersionUID; residual #2444–#2446)
Fixes #2440
Refs #2045 #2200

Co-Authored by Grok Build using grok-4.5 with agent main.

Parameterize DCE cataloger and PSDisplayFormatCatalog public APIs with real
generics (Community, Role, Subject, PSSite, PSEntry, String, PSDisplayFormat).
Update folder/wizard consumers and folder community Set<Integer> return type.
Add serialVersionUID on PSDesktopExplorerWindow. Behavioral tests for catalog
fromXml helpers and getDisplayFormatId null rejection.

Partial for #2384 — desktop window this-escape + status/monitor residual left.
Refs #2045 #2200 #2440

> Co-Authored by Grok Build using grok-4.5 with agent main.
@kilo-code-bot

kilo-code-bot Bot commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (18 files)
  • docs/ai-generated/code-reviews/issue-2384-cataloger-typing-erlang.md
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSDisplayFormatCatalog.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSFolderAclEditorDialog.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSFolderActionManager.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSFolderGeneralPanel.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSSearchViewActionManager.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/catalogers/PSCommunityCataloger.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/catalogers/PSCommunityContentTypeMapperCataloger.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/catalogers/PSGlobalTemplateCataloger.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/catalogers/PSLocaleCataloger.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/catalogers/PSRoleCataloger.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/catalogers/PSSiteCataloger.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/catalogers/PSSubjectCataloger.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/javafx/PSDesktopExplorerWindow.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/wizards/PSCommunityMappingsPage.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/wizards/PSCopySiteNamePage.java
  • modules/DesktopContentExplorer/src/test/java/com/percussion/cx/PSDisplayFormatCatalogTest.java
  • modules/DesktopContentExplorer/src/test/java/com/percussion/cx/catalogers/PSCatalogerTypingTest.java

Reviewed by step-3.7-flash · Input: 104.8K · Output: 25K · Cached: 937.2K

Review guidance: REVIEW.md from base branch main

@natechadwick
natechadwick merged commit c8bab64 into main Aug 8, 2026
6 checks passed
@natechadwick
natechadwick deleted the fix/issue-2384-cataloger-typing branch August 8, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.5 Grok 4.5 model operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[8.2] perc-content-explorer: cataloger Collection/Iterator rawtypes (#2045)

2 participants