Repository navigation
fix(perc-content-explorer): cataloger Collection/Iterator typing (#2384) - #2447
Merged
Merged
Conversation
Parameterize DCE cataloger and PSDisplayFormatCatalog public APIs with real generics (Community, Role, Subject, PSSite, PSEntry, String, PSDisplayFormat). Update folder/wizard consumers and folder community Set<Integer> return type. Add serialVersionUID on PSDesktopExplorerWindow. Behavioral tests for catalog fromXml helpers and getDisplayFormatId null rejection. Partial for #2384 — desktop window this-escape + status/monitor residual left. Refs #2045 #2200 #2440 > Co-Authored by Grok Build using grok-4.5 with agent main.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (18 files)
Reviewed by step-3.7-flash · Input: 104.8K · Output: 25K · Cached: 937.2K Review guidance: REVIEW.md from base branch |
natechadwick
approved these changes
Aug 8, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Residual javac
-Xlintbatch forperc-content-explorerunder #2045 / #2200 (issue #2384): clear cataloger Collection/Iterator rawtypes and type PSDisplayFormatCatalog.PSCommunityCataloger,PSRoleCataloger,PSSubjectCataloger,PSSiteCataloger,PSLocaleCataloger,PSGlobalTemplateCataloger,PSCommunityContentTypeMapperCatalogerPSDisplayFormatCatalog:List/Iterator<PSDisplayFormat>PSFolderActionManager(Set<Integer> getFolderCommunities, site loop), search view display formatsPSDesktopExplorerWindow:serialVersionUIDonly (this-escape residual [8.2] perc-content-explorer: PSDesktopExplorerWindow this-escape residual (#2045) #2444)PSCatalogerTypingTest(6),PSDisplayFormatCatalogTest(1)docs/ai-generated/code-reviews/issue-2384-cataloger-typing-erlang.mdPartial for #2384. Also closes cataloger slice #2440 (duplicate inventory of this batch).
Residual filed
Test plan
cd modules/DesktopContentExplorer && ../../mvnw.cmd clean install— BUILD SUCCESSGates
Operator: Grok: night-issue-prs (model grok-4.5)
Partial for #2384 (cataloger + display format + serialVersionUID; residual #2444–#2446)
Fixes #2440
Refs #2045 #2200