fix(perc-toolkit): Xlint batch 1 — real generics + easy wins (#2030)

[natechadwick-intsof]

Summary

Partial Xlint cleanup for perc-toolkit (issue #2030, parent tracker #2200). First PR-sized batch prefers real generics and mechanical easy wins over blanket suppressions.

Live main-source project -Xlint diagnostics: 87 → 26 (~61 cleared).

Main changes

• Boxed constructors (for-removal): ImageEditorWizard, ImageResizeManagerImpl, PSOFileUploadValidation → primitive casts / Boolean.valueOf
• serialVersionUID: ArchivedException, UniqueIdLocatorSet, TrashTask.FatalTaskException
• @deprecated: QueuedEdition class + PublishEditionService deprecated API surface (javadoc-only → annotation)
• Servlet generics: MutableHttpServletRequestWrapper Map/Enumeration overrides match Jakarta API
• Collections: PSOMutableUrl, PSOParseUrlQueryString, SimplifyParameters, PSOListTools, relationship/folder/extension raw Iterator consumers
• JAXB: ItemRestServiceImpl / ItemServiceHelper use JAXBContext.newInstance(Item.class)
• equals/hashCode: PSOSlotContents.SlotItemComparator

Tests

• PSOMutableUrlTest — toString / setParam
• PSOParseUrlQueryStringTest — single + multi-value accumulation
• PSOSlotContentsTest.testSlotItemComparatorEqualsHashCodeContract
• UniqueIdLocatorSetTest.testDefinesSerialVersionUid

Residual

Remaining diagnostics tracked in #2419 (this-escape sites, PSORequestContext parent override cascade, PropertyData serial field).

Test plan

• cd modules/perc-toolkit && ../../mvnw.cmd clean install — BUILD SUCCESS
• Tests run: 223, Failures: 0, Errors: 0, Skipped: 16
• Main-source warnings 87 → 26
• No new production behavior beyond type-safe APIs already used with raw types

Gates

• Erlang-style self-review: docs/ai-generated/code-reviews/issue-2030-perc-toolkit-xlint-batch1-erlang.md
• Pre-PR Maven: standalone module clean install green
• Operator: Grok: night-issue-prs (model grok-4.5)

Partial for #2030
Refs #2200
Residual: #2419

Co-Authored by Grok Build using grok-4.5 with agent main.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (27 files)

• docs/ai-generated/code-reviews/issue-2030-perc-toolkit-xlint-batch1-erlang.md
• modules/perc-toolkit/src/main/java/com/percussion/pso/imageedit/web/ImageEditorWizard.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/imageedit/web/impl/ImageResizeManagerImpl.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/jexl/PSOListTools.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/legacy/PSOProxyQueryResource.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/relationshipbuilder/PSRelationshipHelperService.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/restservice/impl/ArchivedException.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/restservice/impl/ItemRestServiceImpl.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/restservice/utils/ItemServiceHelper.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/tasks/TrashTask.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/utils/MutableHttpServletRequestWrapper.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/utils/PSOMutableUrl.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/utils/PSOParseUrlQueryString.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/utils/PSOSlotContents.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/utils/PSOSlotRelations.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/utils/SimplifyParameters.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/utils/UniqueIdLocatorSet.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/validation/PSOFileUploadValidation.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/workflow/PSOSwitchCommunityWorkflowAction.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/workflow/PSOWFActionDispatcher.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/workflow/PSOWFActionService.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/workflow/PublishEditionService.java
• modules/perc-toolkit/src/main/java/com/percussion/pso/workflow/QueuedEdition.java
• modules/perc-toolkit/src/main/java/com/percussion/soln/listbuilder/FolderTools.java
• modules/perc-toolkit/src/test/java/test/percussion/pso/utils/PSOMutableUrlTest.java
• modules/perc-toolkit/src/test/java/test/percussion/pso/utils/PSOParseUrlQueryStringTest.java
• modules/perc-toolkit/src/test/java/test/percussion/pso/utils/PSOSlotContentsTest.java
• modules/perc-toolkit/src/test/java/test/percussion/pso/utils/UniqueIdLocatorSetTest.java

---

_{Reviewed by step-3.7-flash · Input: 237.3K · Output: 32.6K · Cached: 3M}

_{Review guidance: REVIEW.md from base branch main}