Skip to content

[8.2] Resolve javac warnings in perc-server-ui-cmp module #2033

Description

@vijaya-boddipudi

Description
The perc-server-ui-cmp module currently completes its build successfully, but still reports Java compiler (javac) and/or Javadoc source warnings that should be cleaned up to improve code quality and maintain a warning-free build.

Cleaning these issues will improve API documentation consistency and help maintain overall code quality.

Module

perc-server-ui-cmp

Build Summary

  • Module: perc-server-ui-cmp
  • Build Status: SUCCESS
  • Reactor Index: 31
  • Total Diagnostics: 100
  • Javac Warnings: 100 (unique: 90)
  • Javac Errors: 0
  • Javadoc Warnings: 0
  • Javadoc Errors: 0
  • Analysis Warnings: 0
  • Analysis Errors: 0

Expected Result

  • The module should build without any javac or javadoc warnings or errors.
  • All source files should compile cleanly under JDK 21 with the project's -Xlint:all settings.
  • Public classes, interfaces, methods, constructors, fields, and parameters should contain complete and valid Javadoc.

Javadoc generation should complete cleanly without warnings.

Actual Result

The module builds with status SUCCESS, but 100 diagnostic message(s) are reported during compilation.

Acceptance Criteria

  • Resolve all javac and javadoc warnings in the perc-server-ui-cmp module.
  • Ensure all public APIs have complete and valid Javadoc.
  • Verify the module builds successfully with zero javac errors, zero javadoc errors, and zero javadoc warnings.
  • Confirm no regressions are introduced during cleanup.

Documents to refer and follow:
java-api-writing-specs.md
javadoc-checklist.md
javadoc-spec-summary.md
javadoc-tool-architecture.md
javadoc-tool-comments.md

Activity

  1. added this to the 8.2 milestone on Aug 5, 2026
  2. vijaya-boddipudi commented on Aug 6, 2026

    @vijaya-boddipudi
    CollaboratorAuthor

    Status update (2026-08-06): The PR for this issue (#2107) currently uses @SuppressWarnings annotations rather than actual code fixes. Per the team's current strategy, those suppressions are being replaced with real fixes — parameterising raw collections (List → List<T>), qualifying static method calls by class name, and removing redundant casts. A follow-up commit will be pushed to #2107 shortly with proper code fixes in place of the suppressions. Will update this issue when that lands.

  3. vijaya-boddipudi commented on Aug 6, 2026

    @vijaya-boddipudi
    CollaboratorAuthor

    Rework landed (commit 0a712b4): Replaced the 2 fixable warnings (static method + static variable qualifier) in PSFieldSelectionEditorDialog with real code fixes (PSDialog.createGroupBorder(...), PSChoiceFilter.DependentField.TYPE_OPTIONAL), removed 3 redundant casts in lookupField() and one in prepareComboData(), and parameterised m_availSelectorComboBox and prepareComboData() with <String>. The class-level @SuppressWarnings still carries rawtypes/unchecked for the ~40 remaining warnings, which require parameterising the legacy IPSPropertyPanel/IPSTableModel surface (tracked as a follow-up under this issue). Build verified with mvn clean install — 0 warnings in this file, 9 module-wide suppress-only warnings (varargs/serial) remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

8.2This issue found in 8.2 releasetech-debttech debt

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions