fix: respect ICM setting basket.maxItemQuantity #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
approved these changes
Feb 1, 2022
SGrueber
added a commit
that referenced
this pull request
May 19, 2022
* docs: add migration hint Co-authored-by: Silke <s.grueber@intershop.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
product maxOrderQuantity defaults to 100 and does not consider ICM server setting for basket.maxItemQuantity
What Is the New Behavior?
ICM server setting for basket.maxItemQuantity is used as validator for product quantity if no specific settings are defined on the product.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#73724
It looks like the ICM API still does not support getting maxOrderQuantity and stepOrderQuantity attributes in the list call... 😢