refactor: use the ICM channel preference to configure the advancedVar… #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
refactor/advanced_variation_handling_config
branch
from
0f6212e
to
de570d0
Compare
…iationHandling instead of the feature toggle of the same name
SGrueber
force-pushed
the
refactor/advanced_variation_handling_config
branch
from
de570d0
to
0500882
Compare
MaxKless
approved these changes
Jan 27, 2022
|
|
||
| // workaround: overrideSelector is not working for selectors with parameters https://github.com/ngrx/platform/issues/2717 | ||
| store$.overrideSelector(getServerConfig, { | ||
| _config: { preferences: { ChannelPreferences: { EnableAdvancedVariationHandling: true } } }, |
SGrueber
added a commit
that referenced
this pull request
May 19, 2022
…iationHandling instead of the feature toggle of the same name (#991) BREAKING CHANGES: The feature toggle 'advancedVariationHandling' has been removed. Use the ICM channel preference for 'Variations List View' now. (see [Migrations / 1.4 to 2.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#14-to-20) for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iationHandling instead of the feature toggle of the same name
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The feature toggle 'advancedVariationHandling' is used to configure how variations should be displayed and behave.
What Is the New Behavior?
Instead, the ICM channel preference 'advancedVariationHandling' is used to configure how variations should be displayed and behave.
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No
Other Information
You will find the preference as 'List View' in the ICM backoffice under Channel Preferences -> Product Variations. This preferences is available per REST with ICM release 7.10.34.0
AB#73600