-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use the ICM channel preference to configure the advancedVar… #991
Conversation
0f6212e
to
de570d0
Compare
…iationHandling instead of the feature toggle of the same name
de570d0
to
0500882
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with the tests. PR looks great :)
|
||
// workaround: overrideSelector is not working for selectors with parameters https://github.com/ngrx/platform/issues/2717 | ||
store$.overrideSelector(getServerConfig, { | ||
_config: { preferences: { ChannelPreferences: { EnableAdvancedVariationHandling: true } } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good solution 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx :-)
…iationHandling instead of the feature toggle of the same name (#991) BREAKING CHANGES: The feature toggle 'advancedVariationHandling' has been removed. Use the ICM channel preference for 'Variations List View' now. (see [Migrations / 1.4 to 2.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#14-to-20) for more details.
…iationHandling instead of the feature toggle of the same name
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The feature toggle 'advancedVariationHandling' is used to configure how variations should be displayed and behave.
What Is the New Behavior?
Instead, the ICM channel preference 'advancedVariationHandling' is used to configure how variations should be displayed and behave.
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No
Other Information
You will find the preference as 'List View' in the ICM backoffice under Channel Preferences -> Product Variations. This preferences is available per REST with ICM release 7.10.34.0
AB#73600