Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
[x] Application / infrastructure changes
What Is the Current Behavior?
ShellModule
is imported inSharedModule
so all components declared there can be re-used in the whole application.What Is the New Behavior?
ShellModule
is not reused anymoreSharedModule
and lazy components for them should be added toShellModule
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Following up on the ideas discussed with @ismail-codinglab and @adrianResler in #551, this PR disconnects
ShellModule
andSharedModule
. The modifiedlazy-component
schematic (will be introduced with #496) makes it possible to moveish-search-box
to shared and the lazy basket item list (introduced in #528) movesish-product-image
to shared. In total this allows a redesign ofShellModule
to no longer be re-used inSharedModule
.This also optimizes the initial bundle size further more.
This PR is based on that previous work still in review, so I added the wait label.