perf: shell as standalone module #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
refactoring
Base automatically changed from
refactor/product-selector-memoization
to
develop
February 23, 2021 16:07
dhhyi
force-pushed
the
perf/shell-as-standalone-module
branch
from
e04995f
to
bcb67fb
Compare
dhhyi
force-pushed
the
perf/shell-as-standalone-module
branch
from
bcb67fb
to
14ae558
Compare
shauke
requested review from
shauke and
MaxKless
and removed request for
shauke
shauke
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
[x] Application / infrastructure changes
What Is the Current Behavior?
ShellModuleis imported inSharedModuleso all components declared there can be re-used in the whole application.What Is the New Behavior?
ShellModuleis not reused anymoreSharedModuleand lazy components for them should be added toShellModuleDoes this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Following up on the ideas discussed with @ismail-codinglab and @adrianResler in #551, this PR disconnects
ShellModuleandSharedModule. The modifiedlazy-componentschematic (will be introduced with #496) makes it possible to moveish-search-boxto shared and the lazy basket item list (introduced in #528) movesish-product-imageto shared. In total this allows a redesign ofShellModuleto no longer be re-used inSharedModule.This also optimizes the initial bundle size further more.
This PR is based on that previous work still in review, so I added the wait label.