-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: product selector memoization #528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
refactor/product-selector-memoization
branch
10 times, most recently
from
February 10, 2021 13:28
376663e
to
be437c6
Compare
dhhyi
force-pushed
the
refactor/product-selector-memoization
branch
14 times, most recently
from
February 16, 2021 09:15
6c68294
to
2b27cb8
Compare
…implify products effects
… category in product context
dhhyi
force-pushed
the
refactor/product-selector-memoization
branch
from
February 22, 2021 23:11
e2f1574
to
51ba25c
Compare
MaxKless
previously approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
products selectors use lodash
memoize
.What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No