feat: fallback to loading when encountering proxy timeout #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
research
4 tasks
dhhyi
force-pushed
the
feat/fallback-loading-when-timeout-2
branch
from
86ace9d
to
2e12e9c
Compare
dhhyi
added a commit
that referenced
this pull request
Sep 25, 2023
dhhyi
force-pushed
the
feat/fallback-loading-when-timeout-2
branch
from
2e12e9c
to
879b600
Compare
dhhyi
added a commit
that referenced
this pull request
Sep 25, 2023
dhhyi
force-pushed
the
feat/fallback-loading-when-timeout-2
branch
from
879b600
to
82a3956
Compare
dhhyi
force-pushed
the
feat/fallback-loading-when-timeout-2
branch
from
82a3956
to
25907bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
High loads on SSR (as well as improper configuration or technical debt) can exhaust all rendering processes and users get long loading times or timeouts.
What Is the New Behavior?
If a timeout is encountered, the loading page will be sent to the user so that Angular can boot up on the client. This does not give the user a full page response, but he can use the webshop. Meanwhile the nginx waits for rendering to finish and caches the page.
replaces #1477
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
TODO/Discussion
Other Information
AB#89692