Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallback to loading when encountering proxy timeout #1477

Closed
wants to merge 2 commits into from

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Aug 11, 2023

PR Type

[x] Feature

What Is the Current Behavior?

High loads on SSR (as well as improper configuration or technical debt) can exhaust all rendering processes and users get long loading times or timeouts.

What Is the New Behavior?

If a timeout is encountered, the loading page will be sent to the user so that Angular can boot up on the client. This does not give the user a full page response, but he can use the webshop.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

TODO/Discussion

  • make timeout configurable
  • reduce code duplication
  • assure the loading page is always available and not unavailable to high load as well
  • research if it is possible to cache the timeout-ed response after it is finally rendered (with built-in methods, it is discarded), or if the SSR rendering can be cancelled

Other Information

AB#88480

@dhhyi dhhyi added nice to have Something that we can all live without, but will really improve a certain unimportant aspect performance Performance improvements labels Aug 11, 2023
@dhhyi dhhyi self-assigned this Aug 11, 2023
@dhhyi dhhyi added the research Exploration for fancy new stuff label Aug 11, 2023
@dhhyi
Copy link
Collaborator Author

dhhyi commented Sep 22, 2023

replaced by #1511

@dhhyi dhhyi closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts nice to have Something that we can all live without, but will really improve a certain unimportant aspect performance Performance improvements research Exploration for fancy new stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant