Merged
Conversation
Contributor
Author
|
We @ yanado.com are thinking of using this library for our cause but due doe company removal bug we are unable to continue. Could you let me know if you plan to use this fix or not so that we can continue off from my fork? Thank you . |
Merged
Contributor
|
Hi @savicprvoslav, thanks for fixing this! Sorry it took so long to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have fixed a bug Cannot remove users from Company #70 .
Lets observe this code:
In the line where removeCompany is called we add company to RemoveCompanyCollection and this is good part but company is not removed from CompanyCollection and at the same time we allow adding already removed company. This results in not removing the user from company.
Solution to the problem is to filter CompanyCollection and remove all Companies from RemoveCompanyCollection.