-
Notifications
You must be signed in to change notification settings - Fork 187
5.14 #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: retr0-init <146389702+retr0-init@users.noreply.github.com>
* added type 36 & 38 * added type 46 * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com>
* feat: add `thread_name` field in the webhook field * ci: correct from checks. * fixed: Add a missing comma * feat: check exclusive relationship between `thread` and `thread_name` * ci: correct from checks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the voice tests are unreliable and I still haven't figured out why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides those, I've tested on python3.10 and python3.11 and it works normally.
* Feat: Add support for Application Emoji * Fix emoji tests * fix: make sure to await response Original code from #1746, which was closed for some reason. * feat: adjust methods in CustomEmoji to respect app emojis * fix: adjust app emoji code based off testing --------- Co-authored-by: AstreaTSS <25420078+AstreaTSS@users.noreply.github.com>
* feat: add guild_count property * docs: remove incorrect comment Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com> --------- Signed-off-by: Astrea <25420078+AstreaTSS@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested and happy. Pytest error appears to be transient
New release soon
But I want #1742 to be merged first.