Forgot await #1746
Closed
Forgot await #1746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstreaTSS
added a commit
that referenced
this pull request
Jan 2, 2025
Original code from #1746, which was closed for some reason.
silasary
added a commit
that referenced
this pull request
Jan 3, 2025
* Feat: Add support for Application Emoji * Fix emoji tests * fix: make sure to await response Original code from #1746, which was closed for some reason. * feat: adjust methods in CustomEmoji to respect app emojis * fix: adjust app emoji code based off testing --------- Co-authored-by: AstreaTSS <25420078+AstreaTSS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Simple typo where you missed an await when fetching the application emoji.
Changes
self._client.http.get_application_emoji(self.id, emoji_id)Related Issues
Test Scenarios
Emoji = await ctx.bot.app.fetch_emoji(your_id)is the simplest way to test.Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files