Skip to content

5.12.0 #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Apr 30, 2024
Merged

5.12.0 #1665

merged 48 commits into from
Apr 30, 2024

Conversation

silasary
Copy link
Member

@silasary silasary commented Apr 23, 2024

Pull Request Type

  • Release

Description

I want to get the enum fix out the door, but realistically, it's been too long since a release regardless.

Changes

See commits.

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

pre-commit-ci bot and others added 30 commits November 20, 2023 19:56
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.1.5 → v0.1.6](astral-sh/ruff-pre-commit@v0.1.5...v0.1.6)
…#1585)

* fix: assume ratelimit reset after is 0 if small amount

* fix: set remaining to 1 under edge case

* fix: only reset if remaining is 0
ci: migrate ruff 0.1.5 -> 0.1.6
* feat: add safety_alerts_channel_id to http modify_guild method

* feat: add security_alert_channel to guild model
There is a type of embed type missing. The auto moderation notification is added to the enum.

Signed-off-by: retr0-init <146389702+retr0-init@users.noreply.github.com>
Co-authored-by: LordOfPolls <dev@lordofpolls.com>
* feat: add nonce and enforce_nonce to SendMixin

* fix: oops
* fix: Correct the return type of fetch_channels

Signed-off-by: retr0-init <146389702+retr0-init@users.noreply.github.com>

* fix: Revert return type of fetch_channels for GuildWidget

This is meant to be TYPE_VOICE_CHANNEL due to it being a GuildWidget, so this should be reverted.
#1622 (review)

Signed-off-by: retr0-init <146389702+retr0-init@users.noreply.github.com>

---------

Signed-off-by: retr0-init <146389702+retr0-init@users.noreply.github.com>
Co-authored-by: LordOfPolls <dev@lordofpolls.com>
* feat: ability to define which shards connect

* refactor: AutoShardedClient's only_shards to shard_ids
* fix: fixed change_presence function docs

* ci: correct from checks.

---------

Co-authored-by: LordOfPolls <dev@lordofpolls.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
You can invite people to a forum, after all.
* feat: add toggle for fail_if_not_exists for PrefixedContext.reply

* docs: parity with other fail_if_not_exists
* ci: weekly check.

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.1.6 → v0.3.2](astral-sh/ruff-pre-commit@v0.1.6...v0.3.2)
- [github.com/psf/black: 23.11.0 → 24.2.0](psf/black@23.11.0...24.2.0)

* ci: correct from checks.

* chore: Acknowledge where we're intentionally discarding created tasks (RUF006)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com>
Updates the Error Tracking guide to use SENTRY_DSN in line with Sentry.io documentation, as well as any other references of "Sentry token", such as in the setup error message.

Add `dsn` to args of interactions.ext.sentry.setup(). This argument will be used over `token` if set, but existing users who use `load_extension(..., token="dsn")` should not be affected by this fix.
* docs: improve slash command guide

* fix: oops

* fix: grammar
TyrantKingBen and others added 17 commits March 30, 2024 03:55
* add has_any_role

* Add missing stub

* ci: correct from checks.

---------

Co-authored-by: LordOfPolls <dev@lordofpolls.com>
Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* [feat] Add CronTrigger

* [feat] Add timezone support to CronTrigger

* docs: utc -> tz rename

Signed-off-by: 18 <111544899+xvi-ii@users.noreply.github.com>

* ci: correct from checks.

* docs: specify tz as datetime attribute

I'm aware that datetime is not what it actually is, but we shouldn't be using private data types in our docstrings. Developers will additionally be using it as a reference, not the literal representation when using

Signed-off-by: 18 <111544899+xvi-ii@users.noreply.github.com>

---------

Signed-off-by: 18 <111544899+xvi-ii@users.noreply.github.com>
Co-authored-by: 18 <111544899+xvi-ii@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Add croniter to requirements.txt, and change the import of the stub-only `datetime._TzInfo` to only run when type checking
As None is a valid value now, as of 3.12.3 it cannot be used
for the name python/cpython#116040
* feat: add ctx.defer() kwarg suppress_error

* fix: docstring oops

* docs: remove note on specific use case

* docs: refactor defer usage note for clarity

* docs: use orig "followup" than "new one" on modal

* feat: suppress hybrid cmd trigger typing errors
…e channel it belongs to has been expired (#1648)

Fixes #1644
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 55.17241% with 169 lines in your changes are missing coverage. Please review.

Project coverage is 46.18%. Comparing base (0129d53) to head (b0abff1).
Report is 23 commits behind head on stable.

Files Patch % Lines
interactions/models/internal/context.py 39.47% 23 Missing ⚠️
interactions/client/client.py 21.42% 22 Missing ⚠️
interactions/models/discord/onboarding.py 83.07% 11 Missing ⚠️
interactions/models/discord/timestamp.py 23.07% 10 Missing ⚠️
...eractions/api/events/processors/reaction_events.py 18.18% 9 Missing ⚠️
interactions/client/smart_cache.py 12.50% 7 Missing ⚠️
interactions/ext/hybrid_commands/context.py 0.00% 7 Missing ⚠️
interactions/ext/paginators.py 0.00% 6 Missing ⚠️
interactions/models/discord/user.py 40.00% 6 Missing ⚠️
...nteractions/api/http/http_requests/entitlements.py 66.66% 5 Missing ⚠️
... and 23 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           stable    #1665      +/-   ##
==========================================
+ Coverage   45.96%   46.18%   +0.22%     
==========================================
  Files         144      148       +4     
  Lines       15437    15772     +335     
==========================================
+ Hits         7096     7285     +189     
- Misses       8341     8487     +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silasary silasary merged commit 7e01223 into stable Apr 30, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.