feat: option to defer without raising errors #1661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Add a bool kwarg
suppress_error
(defaultFalse
) todefer()
(oftenctx.defer()
) in different instances ofInteractionContext
. If enabled, deferring an interaction response again will not raise an error, which is the current behavior ofctx.defer()
.One example use case of this feature, which I use in a bot of mine, is using
auto_defer(time_until_defer=...)
andctx.defer()
together, making the command defer after either a certain point or a set time, whichever is reached first.Technical Description
This feature moves/renames the current
defer()
to_defer()
(note the underscore). The newdefer()
is a wrapper for_defer()
, which would suppress relevant errors (AlreadyDeferred
,AlreadyResponded
, andHTTPException
) usingcontextlib.suppress()
. A similar method of error suppression is already used byAutoDefer
.Changes
suppress_error
todefer()
False
in line with current behaviordefer()
InteractionContext
,ComponentContext
,ContextMenuContext
,ModalContext
, andHybridContext
defer()
regarding the method overriding ephemeral response settingsRelated Issues
Test Scenarios
Use the following callback coroutine to an interaction command (slash command, component, context menu, modal, hybrid slash command). Tested on all five.
If
suppress_error=False
or unspecified: Command responds with "Error raised" forAlreadyDeferred
.If
suppress_error=True
: Command responds with "No error".Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files