Display caps for vaCopy #1187
Merged
Display caps for vaCopy #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XinfengZhang
force-pushed
the
display_caps
branch
from
dfdb30b to
897b040
Compare
dvrogozh
suggested changes
Apr 26, 2021
dmitryermilov
approved these changes
Apr 26, 2021
Xiaogangli-intel
approved these changes
Apr 28, 2021
|
ping? libva 1.12 is out with this intel/libva#513 merged, but without support in media-driver :) |
XinfengZhang
force-pushed
the
display_caps
branch
2 times, most recently
from
0aad94e to
cffe5a8
Compare
fenhu
reviewed
Aug 30, 2021
| @@ -61,7 +61,7 @@ | |||
| #if VA_MAJOR_VERSION < 1 | |||
| #define DDI_CODEC_GEN_MAX_DISPLAY_ATTRIBUTES 4 | |||
| #else | |||
| #define DDI_CODEC_GEN_MAX_DISPLAY_ATTRIBUTES 0 // set it to zero, unsupported. | |||
| #define DDI_CODEC_GEN_MAX_DISPLAY_ATTRIBUTES 1 | |||
There was a problem hiding this comment.
How about change to DDI_MEDIA_GEN_MAX_DISPLAY_ATTRIBUTES
fenhu
reviewed
Aug 30, 2021
| return VA_STATUS_SUCCESS; | ||
| } | ||
|
|
||
| VAStatus MediaLibvaCaps::SetDisplayAttributes( |
There was a problem hiding this comment.
pls remove it if media doesn't need it.
fenhu
reviewed
Aug 30, 2021
| { | ||
| switch(attribList->type) | ||
| { | ||
| case VADisplayAttribSubDevice: |
There was a problem hiding this comment.
Does it for VADisplayAttribCopy?
XinfengZhang
force-pushed
the
display_caps
branch
2 times, most recently
from
1b75ec9 to
72711ad
Compare
fenhu
approved these changes
Sep 3, 2021
XinfengZhang
force-pushed
the
display_caps
branch
from
72711ad to
1aca4f1
Compare
move the implementation of display attributes into MediaLibvaCaps class inherit display attributes from MediaLibvaCaps for Gen12 Signed-off-by: XinfengZhang <carl.zhang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/libva#513