report the capability of vaCopy support #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XinfengZhang
force-pushed
the
mcp_attrib
branch
from
c64c36d to
ed6d0fb
Compare
dvrogozh
requested changes
Apr 7, 2021
va/va.h
Outdated
| * adaptor / platform attributes. read only. specify whether vaCopy support on current HW | ||
| * the value of each bit should equal to 1 << VA_EXEC_MODE_XXX | ||
| */ | ||
| VADisplayAttibCopy = 19, |
emersion
reviewed
Apr 8, 2021
emersion
reviewed
Apr 8, 2021
emersion
reviewed
Apr 8, 2021
va/va.h
Outdated
| * App could call vaQueryDisplayAttributes/vaGetDisplayAttributes to query these attributes | ||
| * at anytime after vaInitialize, but only could call vaSetDisplayAttributes for these attributes | ||
| * after vaInitialize and before any other function call if the attributes is settable. | ||
| * To distinguish these two types display attributes, this display adaptor related attributres |
dmitryermilov
approved these changes
Apr 9, 2021
XinfengZhang
force-pushed
the
mcp_attrib
branch
2 times, most recently
from
88701a9 to
e448c30
Compare
XinfengZhang
added a commit
to XinfengZhang/media-driver
that referenced
this pull request
Apr 25, 2021
it is against intel/libva#513 Signed-off-by: XinfengZhang <carl.zhang@intel.com>
This was referenced Apr 25, 2021
XinfengZhang
added a commit
to XinfengZhang/media-driver
that referenced
this pull request
Apr 25, 2021
it is against intel/libva#513 Signed-off-by: XinfengZhang <carl.zhang@intel.com>
dvrogozh
reviewed
Apr 26, 2021
va/va.h
Outdated
| @@ -4835,6 +4835,15 @@ VAStatus vaDeassociateSubpicture ( | |||
| * brightness etc. in the rendering process. The application can query what | |||
| * attributes are supported by the driver, and then set the appropriate attributes | |||
| * before calling vaPutSurface() | |||
| * | |||
| * Display attributes also are used to query/set display adaptor (vaDisplay) related information. | |||
There was a problem hiding this comment.
Suggest to rewrite:
* Display attributes can also be used to query/set platform or display adaptor (vaDisplay)
* related information. These attributes do not depend on vaConfig, and could not be used
* for vaPutSurface. Application can use vaQueryDisplayAttributes/vaGetDisplayAttributes
* at anytime after vaInitialize, but (for settable attributes) vaSetDisplayAttributes should be
* called after vaInitialize and before any other function call.
*
* To distinguish these two types of display attributes, display adaptor related attributes
* should be marked as "HW attribute" in the description.
e448c30 to
afd3145
Compare
dvrogozh
approved these changes
Apr 29, 2021
Report vaCopy support, it is a standalone feature , which is related with vaDisplay. not depend on VPP , vaConfig etc. Signed-off-by: Carl Zhang <carl.zhang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carl Zhang carl.zhang@intel.com