Skip to content

[CI] Don't skip E2E tests if only check-* steps in build fail #9912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2023
Merged

[CI] Don't skip E2E tests if only check-* steps in build fail #9912

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b362d47
[CI] Don't skip E2E tests if only check-* steps in build fails
aelovikov-intel Jun 15, 2023
3c00c9e
Try to enable install/upload steps
aelovikov-intel Jun 15, 2023
da4e60e
Now try to enable the jobs
aelovikov-intel Jun 15, 2023
27e4d9d
Merge remote-tracking branch 'origin/sycl' into ci-post-e2e-when-chec…
aelovikov-intel Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/sycl_linux_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ jobs:
container:
image: ${{ inputs.build_image }}
options: -u 1001:1001
outputs:
build_conclusion: ${{ steps.build.conclusion }}
steps:
# GHA requires relative paths for actions. Copy actions from container root
# to CWD.
Expand Down Expand Up @@ -146,6 +148,7 @@ jobs:
run: |
cmake --build $GITHUB_WORKSPACE/build --target check-libdevice
- name: Install
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' }}
# TODO replace utility installation with a single CMake target
run: |
cmake --build $GITHUB_WORKSPACE/build --target deploy-sycl-toolchain
Expand All @@ -159,7 +162,7 @@ jobs:
cmake --build $GITHUB_WORKSPACE/build --target install-llvm-profdata
cmake --build $GITHUB_WORKSPACE/build --target install-compiler-rt
- name: Additional Install for "--shared-libs" build
if: ${{ contains(inputs.build_configure_extra_args, '--shared-libs') }}
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' && contains(inputs.build_configure_extra_args, '--shared-libs') }}
run: |
cmake --build $GITHUB_WORKSPACE/build --target install-clang-libraries
cmake --build $GITHUB_WORKSPACE/build --target install-llvm-libraries
Expand All @@ -172,8 +175,10 @@ jobs:
cmake --build $GITHUB_WORKSPACE/build --target install-clang-tidy

- name: Pack toolchain
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' }}
run: tar -I 'zstd -9' -cf llvm_sycl.tar.zst -C $GITHUB_WORKSPACE/build/install .
- name: Upload toolchain
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' }}
uses: actions/upload-artifact@v3
with:
name: sycl_linux_${{ inputs.build_artifact_suffix }}
Expand All @@ -182,7 +187,7 @@ jobs:
aws-start:
name: Start AWS
needs: build
if: ${{ inputs.lts_aws_matrix != '[]' }}
if: ${{ always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' && inputs.lts_aws_matrix != '[]' }}
uses: ./.github/workflows/aws.yml
secrets: inherit
with:
Expand All @@ -193,7 +198,7 @@ jobs:
needs: [build, aws-start]
# Continue if build was successful. If aws-start is not successful all
# AWS tasks will fail, but all non-AWS tasks should continue.
if: ${{ always() && needs.build.result == 'success' && inputs.lts_matrix != '[]' }}
if: ${{ always() && needs.build.outputs.build_conclusion == 'success' && inputs.lts_matrix != '[]' }}
strategy:
fail-fast: false
matrix:
Expand Down