[CI] Don't skip E2E tests if only check-* steps in build fail #9912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have proper check on the `e2e-tests` job, but it depends on the `aws-start` task and that didn't have the check. That resulted in the `aws-start` being skipped whenever any of `check-*` steps failed and resulted in E2E tests not running even though we can easily run them to get better coverage. This should make our post-commit CI more useful in presence of failures on `check-*` targets during the build stage.
aelovikov-intel
changed the title
bader
reviewed
Jun 15, 2023
| @@ -182,7 +182,7 @@ jobs: | |||
| aws-start: | |||
| name: Start AWS | |||
| needs: build | |||
| if: ${{ inputs.lts_aws_matrix != '[]' }} | |||
| if: ${{ always() && needs.build.result == 'success' && inputs.lts_aws_matrix != '[]' }} | |||
There was a problem hiding this comment.
"That resulted in the aws-start being skipped"
Will this change run only aws-start or E2E tests for all backends?
There was a problem hiding this comment.
My intention is for the latter. Need to wait for the testing to finish to verify. Note that e2e-tests already has the same if: guard at line 208.
There was a problem hiding this comment.
Note that we skip aws in post-commit because lts_aws_matrix is empty there (we only do testing on Intel HW in post-commit).
|
@intel/dpcpp-devops-reviewers , ping. |
|
@steffenlarsen , @cperkinsintel , ping. |
aelovikov-intel
added a commit
that referenced
this pull request
Jun 27, 2023
Same as was done in #9912 for Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have proper check on the
e2e-testsjob, but it depends on theaws-starttask and that didn't have the check. That resulted in theaws-startbeing skipped whenever any ofcheck-*steps failed and resulted in E2E tests not running even though we can easily run them to get better coverage.This should make our post-commit CI more useful in presence of failures on
check-*targets during the build stage.