[SYCL][UR][L0] Fix casting in UR for boolean #9654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be similar to #9561 and caused by adapter voluntarily interpreting how bool is returned.
I think ur_bool_t should either be removed, or redefined as uint32_t |
smaslov-intel
approved these changes
May 30, 2023
pi_bool is uint32_t and ur_bool_t is uint8_t, so to make sure correct functionality is maintained, use uint32_t as replacement for pi_bool, instead of ur_bool_t. Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
@smaslov-intel : Please see here oneapi-src/unified-runtime#556 |
smaslov-intel
approved these changes
May 30, 2023
smaslov-intel
approved these changes
May 30, 2023
|
@intel/llvm-gatekeepers : could we merge this? |
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
pi_bool is uint32_t and ur_bool_t is uint8_t, so to make sure correct functionality is maintained, use uint32_t as replacement for pi_bool, instead of ur_bool_t. Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pi_bool is uint32_t and ur_bool_t is uint8_t, so to make sure correct functionality is maintained, use uint32_t as replacement for pi_bool, instead of ur_bool_t.