Skip to content

[SYCL] Fix pi2ur conversion of bool info queries #9672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

callumfare
Copy link
Contributor

Also fix:

  • Uninitialized stype values in UR queries
  • Missing PI_KERNEL_INFO_NUM_REGS mapping

@callumfare callumfare requested a review from a team as a code owner May 31, 2023 15:07
@callumfare
Copy link
Contributor Author

@jandres742 This is the bool conversion we discussed (and some other miscellaneous fixes)

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR bool type needs to change instead so there is no mismatch

@callumfare callumfare temporarily deployed to aws May 31, 2023 15:33 — with GitHub Actions Inactive
@callumfare callumfare temporarily deployed to aws May 31, 2023 17:06 — with GitHub Actions Inactive
Also fix:
* Uninitialized stype values in UR queries
* Missing PI_KERNEL_INFO_NUM_REGS mapping
@callumfare callumfare force-pushed the callum/pi2ur_bool_fix branch from d9e2a85 to 1d3e841 Compare June 12, 2023 11:19
@callumfare callumfare temporarily deployed to aws June 12, 2023 11:38 — with GitHub Actions Inactive
@callumfare callumfare temporarily deployed to aws June 12, 2023 12:19 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor

@intel/llvm-gatekeepers : please merge when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants