[SYCL][Test] Remove check_has.cpp dependency on metadata order #9642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check_has.cpp strictly depends on order of sycl_declared_aspects and srcloc metadata which is not guaranteed by compiler. This test aims to check IR for device_has(aspect..., we can keep sycl_declared_aspects and remove srcloc to avoid the dependency. Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90
changed the title
steffenlarsen
pushed a commit
that referenced
this pull request
Nov 9, 2023
Previously, we committed #9642 aiming to break dependency on metadata order for check_has.cpp but the commit was broken unexpectedly. This PR re-lands it. --------- Signed-off-by: jinge90 <ge.jin@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_has.cpp strictly depends on order of sycl_declared_aspects and srcloc metadata which is not guaranteed by compiler.
This test aims to check IR for device_has(aspect..., we can keep sycl_declared_aspects and remove srcloc to avoid the dependency.