-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL][TEST] Remove check_has.cpp dependency on metadata order #11809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @steffenlarsen and @maarquitos14 |
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 why was it reverted earlier? Did it cause any issue? |
Hi, @maarquitos14 |
I see, thanks for explaining. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi, @intel/llvm-gatekeepers |
Previously, we committed #9642 aiming to break dependency on metadata order for check_has.cpp but the commit was broken unexpectedly. This PR re-lands it.