[SYCL] Implement proper queries for aspect::ext_oneapi_srgb #9243
Conversation
Plugins that don't support functionality must report false, not PI_INVALD_VALUE.
| @@ -44,6 +44,7 @@ const int UR_EXT_DEVICE_INFO_FREE_MEMORY = UR_EXT_DEVICE_INFO_END - 13; | |||
| // const int ZER_EXT_DEVICE_INFO_IMAGE_MAX_ARRAY_SIZE = | |||
| // UR_DEVICE_INFO_IMAGE_MAX_ARRAY_SIZE; | |||
| const int UR_EXT_DEVICE_INFO_MEM_CHANNEL_SUPPORT = UR_EXT_DEVICE_INFO_END - 15; | |||
| const int UR_EXT_DEVICE_INFO_IMAGE_SRGB = UR_EXT_DEVICE_INFO_END - 16; | |||
There was a problem hiding this comment.
@kbenzie: please take it into UR
There was a problem hiding this comment.
We alreayd have UR_DEVICE_INFO_IMAGE_SRGB in ur_device_info_t. I think that should be sufficient.
There was a problem hiding this comment.
Having checked out this branch I can see UR_DEVICE_INFO_IMAGE_SRGB is defined in the ur_api.h header and should be used instead of this new symbol.
sycl/plugins/cuda/pi_cuda.cpp
Outdated
| @@ -2105,6 +2105,11 @@ pi_result cuda_piDeviceGetInfo(pi_device device, pi_device_info param_name, | |||
| return getInfo<pi_bool>(param_value_size, param_value, param_value_size_ret, | |||
| false); | |||
| } | |||
| case PI_DEVICE_INFO_IMAGE_SRGB: { | |||
| // The sRGB images are not supported on HIP device. | |||
There was a problem hiding this comment.
| // The sRGB images are not supported on HIP device. | |
| // The sRGB images are not supported on CUDA. |
| // UNSUPPORTED: cuda | ||
| // UNSUPPORTED: hip | ||
| // Only opencl plugin has implemented the supoort. | ||
| // REQUIRES: opencl |
There was a problem hiding this comment.
Now that the aspect check works, should we maybe just do the check and an early exit instead? In the future we would that to a REQUIRES: aspect_image && aspect_ext_oneapi_srgb or something to that effect.
There was a problem hiding this comment.
The purpose of this test is FileCheck which we can't nicely implement without dynamic LIT features support.
There was a problem hiding this comment.
Oh, I see. Good point. Should we have a TODO just to remind us?
| @@ -44,6 +44,7 @@ const int UR_EXT_DEVICE_INFO_FREE_MEMORY = UR_EXT_DEVICE_INFO_END - 13; | |||
| // const int ZER_EXT_DEVICE_INFO_IMAGE_MAX_ARRAY_SIZE = | |||
| // UR_DEVICE_INFO_IMAGE_MAX_ARRAY_SIZE; | |||
| const int UR_EXT_DEVICE_INFO_MEM_CHANNEL_SUPPORT = UR_EXT_DEVICE_INFO_END - 15; | |||
| const int UR_EXT_DEVICE_INFO_IMAGE_SRGB = UR_EXT_DEVICE_INFO_END - 16; | |||
There was a problem hiding this comment.
Having checked out this branch I can see UR_DEVICE_INFO_IMAGE_SRGB is defined in the ur_api.h header and should be used instead of this new symbol.
intel#9243 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
intel#9243 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
intel#9243 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
intel#9243 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Plugins that don't support functionality must report false, not PI_INVALD_VALUE.
Plugins that don't support functionality must report false, not PI_INVALD_VALUE.