[SYCL] Implement proper queries for aspect::ext_oneapi_srgb (#9243)

Plugins that don't support functionality must report false, not
PI_INVALD_VALUE.

Author: aelovikov-intel

sycl/plugins/cuda/pi_cuda.cpp

@@ -2105,6 +2105,11 @@ pi_result cuda_piDeviceGetInfo(pi_device device, pi_device_info param_name,
     return getInfo<pi_bool>(param_value_size, param_value, param_value_size_ret,
                             false);
   }
+  case PI_DEVICE_INFO_IMAGE_SRGB: {
+    // The sRGB images are not supported on CUDA.
+    return getInfo<pi_bool>(param_value_size, param_value, param_value_size_ret,
+                            false);
+  }
 
     // TODO: Investigate if this information is available on CUDA.
   case PI_DEVICE_INFO_PCI_ADDRESS:
@@ -2114,7 +2119,6 @@ pi_result cuda_piDeviceGetInfo(pi_device device, pi_device_info param_name,
   case PI_DEVICE_INFO_GPU_SUBSLICES_PER_SLICE:
   case PI_DEVICE_INFO_GPU_EU_COUNT_PER_SUBSLICE:
   case PI_DEVICE_INFO_GPU_HW_THREADS_PER_EU:
-  case PI_DEVICE_INFO_IMAGE_SRGB:
     return PI_ERROR_INVALID_VALUE;
 
   default:

sycl/plugins/esimd_emulator/pi_esimd_emulator.cpp

@@ -816,6 +816,9 @@ pi_result piDeviceGetInfo(pi_device Device, pi_device_info ParamName,
   case PI_EXT_INTEL_DEVICE_INFO_MEM_CHANNEL_SUPPORT:
     // The mem-channel buffer property is not supported on the ESIMD emulator.
     return ReturnValue(pi_bool{false});
+  case PI_DEVICE_INFO_IMAGE_SRGB:
+    // The sRGB images are not supported on the ESIMD emulator.
+    return ReturnValue(pi_bool{false});
 
     CASE_PI_UNSUPPORTED(PI_DEVICE_INFO_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS)
     CASE_PI_UNSUPPORTED(PI_DEVICE_INFO_IL_VERSION)
@@ -829,7 +832,6 @@ pi_result piDeviceGetInfo(pi_device Device, pi_device_info ParamName,
     CASE_PI_UNSUPPORTED(PI_DEVICE_INFO_GPU_SUBSLICES_PER_SLICE)
     CASE_PI_UNSUPPORTED(PI_DEVICE_INFO_GPU_EU_COUNT_PER_SUBSLICE)
     CASE_PI_UNSUPPORTED(PI_DEVICE_INFO_MAX_MEM_BANDWIDTH)
-    CASE_PI_UNSUPPORTED(PI_DEVICE_INFO_IMAGE_SRGB)
     CASE_PI_UNSUPPORTED(PI_DEVICE_INFO_ATOMIC_64)
     CASE_PI_UNSUPPORTED(PI_EXT_DEVICE_INFO_ATOMIC_MEMORY_ORDER_CAPABILITIES)
     CASE_PI_UNSUPPORTED(PI_EXT_DEVICE_INFO_ATOMIC_MEMORY_SCOPE_CAPABILITIES)

sycl/plugins/hip/pi_hip.cpp

@@ -1960,6 +1960,11 @@ pi_result hip_piDeviceGetInfo(pi_device device, pi_device_info param_name,
     return getInfo<pi_bool>(param_value_size, param_value, param_value_size_ret,
                             false);
   }
+  case PI_DEVICE_INFO_IMAGE_SRGB: {
+    // The sRGB images are not supported on HIP device.
+    return getInfo<pi_bool>(param_value_size, param_value, param_value_size_ret,
+                            false);
+  }
 
   // TODO: Investigate if this information is available on HIP.
   case PI_DEVICE_INFO_PCI_ADDRESS:
@@ -1971,7 +1976,6 @@ pi_result hip_piDeviceGetInfo(pi_device device, pi_device_info param_name,
   case PI_DEVICE_INFO_GPU_HW_THREADS_PER_EU:
   case PI_DEVICE_INFO_MAX_MEM_BANDWIDTH:
   case PI_EXT_ONEAPI_DEVICE_INFO_BFLOAT16_MATH_FUNCTIONS:
-  case PI_DEVICE_INFO_IMAGE_SRGB:
     setErrorMessage("HIP backend does not support this query",
                     PI_ERROR_INVALID_ARG_VALUE);
     return PI_ERROR_PLUGIN_SPECIFIC_ERROR;

sycl/plugins/unified_runtime/pi2ur.hpp

@@ -788,6 +788,9 @@ inline pi_result piDeviceGetInfo(pi_device Device, pi_device_info ParamName,
   case PI_EXT_INTEL_DEVICE_INFO_MEM_CHANNEL_SUPPORT:
     InfoType = (ur_device_info_t)UR_EXT_DEVICE_INFO_MEM_CHANNEL_SUPPORT;
     break;
+  case PI_DEVICE_INFO_IMAGE_SRGB:
+    InfoType = (ur_device_info_t)UR_DEVICE_INFO_IMAGE_SRGB;
+    break;
   default:
     return PI_ERROR_UNKNOWN;
   };

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero.cpp

@@ -1015,6 +1015,8 @@ ur_result_t urDeviceGetInfo(
   }
   case UR_EXT_DEVICE_INFO_MEM_CHANNEL_SUPPORT:
     return ReturnValue(pi_bool{false});
+  case UR_DEVICE_INFO_IMAGE_SRGB:
+    return ReturnValue(pi_bool{false});
 
   // TODO: Implement.
   default:

sycl/test-e2e/Basic/image/srgba-aspect-check.cpp

@@ -0,0 +1,14 @@
+// RUN: %clangxx -fsycl  -fsycl-targets=%sycl_triple %s -o %t.out
+// RUN: %CPU_RUN_PLACEHOLDER %t.out
+// RUN: %GPU_RUN_PLACEHOLDER %t.out
+// RUN: %ACC_RUN_PLACEHOLDER %t.out
+
+#include <sycl/sycl.hpp>
+
+int main() {
+  sycl::queue q;
+  // Ensure that plugins that don't implement the support can still handle the
+  // aspect query.
+  std::ignore = q.get_device().has(sycl::aspect::ext_oneapi_srgb);
+  return 0;
+}

sycl/test-e2e/Basic/image/srgba-read.cpp

@@ -2,9 +2,8 @@
 // RUN: %CPU_RUN_PLACEHOLDER %t.out %CPU_CHECK_PLACEHOLDER
 // RUN: %GPU_RUN_PLACEHOLDER %t.out %GPU_CHECK_PLACEHOLDER
 
-// XFAIL: level_zero
-// UNSUPPORTED: cuda
-// UNSUPPORTED: hip
+// Only opencl plugin has implemented the supoort.
+// REQUIRES: opencl
 
 #include <iostream>
 #include <sycl/sycl.hpp>