-
Notifications
You must be signed in to change notification settings - Fork 772
[SYCL] Throw for invalid global_work_size query #9072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SYCL2020: This descriptor may only be used if the device type is device_type::custom or if the kernel is a built-in kernel. Attempting to use this descriptor for other devices or kernels throws an exception with the errc::invalid error code. The previous implementation is based on handling OpenCL exception, but the other backends don't throw anything, so it works only on OCL. This approch is more generic.
Waiting for #9061 to be merged, because I need isBuiltInKernel() function, which was introduced there. |
I guess |
At first glance, it does not look related, but https://github.com/intel/llvm/actions/runs/4739521267/jobs/8414728080?pr=9113 passed just half an hour ago. Could you try and merge the latest changes in origin/sycl and see if that helps? |
Now there are some more PRs, so we can see that it's unrelated - e.g. #9112 |
Failed Tests (1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SYCL2020:
This descriptor may only be used if the device type is device_type::custom or if the kernel is a built-in kernel. Attempting to use this descriptor for other devices or kernels throws an exception with the errc::invalid error code.
The previous implementation is based on handling OpenCL exception, but the other backends don't throw anything, so it works only on OCL. This approch is more generic.