[SYCL] Throw for invalid info::kernel::num_args query #9061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to SYCL2020 spec: This descriptor may only be used to query a kernel that resides in a kernel bundle that was constructed using a backend specific interoperability function or to query a device built-in kernel, and the semantics of this descriptor are defined by each SYCL backend specification. Attempting to use this descriptor for other kernels throws an exception with the errc::invalid error code. Fow now the only one way to create such kernel bundle - use make_kernel(). And creating bundle from built-in kernels is not fully supported, so it should throw in most cases at the present time.
|
@intel/sycl-language-enabling-triage take a look please. |
AlexeySachkov
approved these changes
Apr 17, 2023
steffenlarsen
approved these changes
Apr 17, 2023
steffenlarsen
approved these changes
Apr 17, 2023
|
@intel/llvm-gatekeepers PR is ready for merge, take a look please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to SYCL2020 spec:
This descriptor may only be used to query a kernel that resides in a kernel bundle that was constructed using a backend specific interoperability function or to query a device built-in kernel, and the semantics of this descriptor are defined by each SYCL backend specification. Attempting to use this descriptor for other kernels throws an exception with the errc::invalid error code.
Fow now the only one way to create such kernel bundle - use make_kernel(). And creating bundle from built-in kernels is not fully supported, so it should throw in most cases at the present time.
Resolves #7630