[mlir][llvm] Verify consistency of llvm.resume and llvm.landingpad types #8909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit af822e2.
Following the steps of the LLVM verifier (https://github.com/llvm/llvm-project/blob/b2c48559c882fd558f91e471c4d23ea7b0c6e718/llvm/lib/IR/Verifier.cpp#L4195), checks in llvm.func verifier are added to ensure consistency of llvm.landingpad operations' result types and llvm.resume operations' input types. As in LLVM, we will allow llvm.resume operations with input values defined by operations other than llvm.landingpad. This commit is a clone of upstream commit 478bd07 (https://reviews.llvm.org/rG478bd0735fc094d3af37e9791df5118a402ae7a7). Signed-off-by: Victor Perez <victor.perez@codeplay.com>
Please, create two separate PRs to avoid squashing. |
victor-eds
commented
Mar 31, 2023
victor-eds
changed the title
Done. Thanks |
|
Merge #8910 reverting the changes before this one. |
sommerlukas
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Checked that the changes here are identical to the upstream patch with which they will eventually be replaced, once we receive it in pull-down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the steps of the LLVM verifier
(https://github.com/llvm/llvm-project/blob/b2c48559c882fd558f91e471c4d23ea7b0c6e718/llvm/lib/IR/Verifier.cpp#L4195),
checks in llvm.func verifier are added to ensure consistency of
llvm.landingpad operations' result types and llvm.resume operations'
input types.
As in LLVM, we will allow llvm.resume operations with input values
defined by operations other than llvm.landingpad.
This commit is a clone of upstream commit
victor-eds@478bd07
(https://reviews.llvm.org/rG478bd0735fc094d3af37e9791df5118a402ae7a7).
Signed-off-by: Victor Perez victor.perez@codeplay.com