[MLIR] Allow llvm.resume with non-landingpad input #8590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes verification of llvm.resume to just fail if there is no llvm.landingpad instruction in the same function with the same type as this instruction's input, more in line with LLVM's verificatino. From LLVM documentation (https://llvm.org/docs/LangRef.html#i-resume): The ‘resume’ instruction requires one argument, which must have the same type as the result of any ‘landingpad’ instruction in the same function. Signed-off-by: Victor Perez <victor.perez@codeplay.com>
|
I'll create a patch upstream when this is merged. |
etiotto
approved these changes
Mar 9, 2023
whitneywhtsang
approved these changes
Mar 10, 2023
|
victor-eds
added a commit
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes verification of llvm.resume to just fail if there is no llvm.landingpad instruction in the same function with the same type as this instruction's input, more in line with LLVM's verification. From LLVM documentation (https://llvm.org/docs/LangRef.html#i-resume):
The ‘resume’ instruction requires one argument, which must have the same type as the result of any ‘landingpad’ instruction in the same function.