Skip to content

[SYCL][InvokeSIMD] Add test for invoke_simd return type error #8772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2023
Merged

[SYCL][InvokeSIMD] Add test for invoke_simd return type error #8772

merged 1 commit into from
Mar 25, 2023

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Mar 24, 2023

@sarnex
[SYCL][InvokeSIMD] Add test for invoke_simd return type error
537582c 
Based on intel/llvm-test-suite#1679

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex requested a review from a team March 24, 2023 21:54
@sarnex sarnex marked this pull request as ready for review March 24, 2023 21:54
@sarnex sarnex requested a review from a team as a code owner March 24, 2023 21:54
@sarnex sarnex requested a review from againull March 24, 2023 21:54
@sarnex
Copy link
Contributor Author

sarnex commented Mar 24, 2023 •
edited
Loading

@v-klochkov Hey, here's the new test. I couldn't actually use -verify because that requires the line number of the error, and it's in a header so it gets pretty ugly. We do it this way in other tests such as here

@sarnex sarnex mentioned this pull request Mar 24, 2023
Merged
@sarnex sarnex temporarily deployed to aws March 24, 2023 22:31 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to aws March 24, 2023 23:03 — with GitHub Actions Inactive
@v-klochkov
Copy link
Contributor

None of failed tests in CI is related to the LIT test added in this PR:
SYCL :: Basic/accessor/accessor.cpp
SYCL :: Basic/multi_ptr.cpp
SYCL :: Basic/multi_ptr_legacy.cpp
SYCL :: DeviceLib/string_test.cpp
SYCL :: DiscardEvents/discard_events_accessors.cpp
SYCL :: Regression/local-arg-align.cpp
SYCL :: Regression/local_accessor_3d_subscript.cpp
SYCL :: Regression/zero_size_local_accessor.cpp

@v-klochkov v-klochkov merged commit d01f85c into intel:sycl Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

@againull againull Awaiting requested review from againull againull was automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarnex @v-klochkov