[SYCL][InvokeSIMD] Delete ret size mismatch test #1679
Conversation
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
|
Compiler PR: intel/llvm#8741 |
|
/verify with intel/llvm#8741 |
| // Check that full compilation works: | ||
| // RUN: %clangxx -fsycl -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %s -o %t.out | FileCheck %s | ||
| // RUN: !%clangxx -fsycl -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %s -o %t.out 2>&1 | FileCheck %s |
There was a problem hiding this comment.
Usually if clang errors, the test will fail because it expects exit code 0. Here an error is thrown, so the exit code is non-0, so the test would fail. '!' makes the non-zero exit code a zero, similar to !bool in cpp.
There was a problem hiding this comment.
Ok, I thought that ! was added to negate the status returned by clang++, but doubted and decided to ask as it is not typical solution.
Typical solution is to use -fsyntax-only and -verify options like here:
https://github.com/intel/llvm/blob/sycl/clang/test/SemaSYCL/esimd-globals-in-sycl-context.cpp#L1
https://github.com/intel/llvm/blob/sycl/clang/test/SemaSYCL/esimd-globals-in-sycl-context.cpp#L18
There was a problem hiding this comment.
yeah good point, i didnt originally write this test so i didn't consider doing compile only. i responded more in my other comment.
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
sarnex
changed the title
Based on intel/llvm-test-suite#1679 Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Based on intel/llvm-test-suite#1679 Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
|
The tests failed in CI are unrelated to the test being deleted in this PR: |
…te#1679) Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
It's moved to the compiler repo.