Skip to content

[SYCL][NFC] Remove unused variable in reduction.hpp #8558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

steffenlarsen
Copy link
Contributor

No description provided.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@dm-vodopyanov
Copy link
Contributor

dm-vodopyanov commented Mar 7, 2023

check-llvm takes too much time (> 1 hour now), this is unrelated to this patch, merging to fix post-commit.

@dm-vodopyanov dm-vodopyanov merged commit 71c4b77 into intel:sycl Mar 7, 2023
@bader
Copy link
Contributor

bader commented Mar 7, 2023

check-llvm takes too much time (> 1 hour now), this is unrelated to this patch, merging to fix post-commit.

Please, fix this ASAP. This issue might hide other performance regressions. check-llvm for > 1 hour should not be acceptable.

@dm-vodopyanov
Copy link
Contributor

check-llvm takes too much time (> 1 hour now), this is unrelated to this patch, merging to fix post-commit.

Please, fix this ASAP. This issue might hide other performance regressions. check-llvm for > 1 hour should not be acceptable.

If I interpreted logs correctly, this is a CI issue: on https://github.com/intel/llvm/actions/runs/4354392854/jobs/7609668032 I pressed "View raw logs", and it showed

2023-03-07T13:03:31.9316973Z Requested labels: Linux, build
2023-03-07T13:03:31.9317074Z Job defined at: intel/llvm/.github/workflows/sycl_linux_build_and_test.yml@refs/heads/sycl
2023-03-07T13:03:31.9317241Z Reusable workflow chain:
2023-03-07T13:03:31.9317282Z intel/llvm/.github/workflows/sycl_precommit.yml@refs/heads/sycl (f66770956fe4000a07979a3b99773772b2980507)
2023-03-07T13:03:31.9317321Z -> intel/llvm/.github/workflows/sycl_linux_build_and_test.yml@refs/heads/sycl (f66770956fe4000a07979a3b99773772b2980507)
2023-03-07T13:03:31.9317342Z Waiting for a runner to pick up this job...
2023-03-07T13:11:10.6983891Z Job is about to start running on the runner: amdgpu-1 (repository)

@bader , can you please double-check that this is a CI issue?

@bader
Copy link
Contributor

bader commented Mar 7, 2023

check-llvm takes too much time (> 1 hour now), this is unrelated to this patch, merging to fix post-commit.

Please, fix this ASAP. This issue might hide other performance regressions. check-llvm for > 1 hour should not be acceptable.

If I interpreted logs correctly, this is a CI issue: on https://github.com/intel/llvm/actions/runs/4354392854/jobs/7609668032 I pressed "View raw logs", and it showed

2023-03-07T13:03:31.9316973Z Requested labels: Linux, build
2023-03-07T13:03:31.9317074Z Job defined at: intel/llvm/.github/workflows/sycl_linux_build_and_test.yml@refs/heads/sycl
2023-03-07T13:03:31.9317241Z Reusable workflow chain:
2023-03-07T13:03:31.9317282Z intel/llvm/.github/workflows/sycl_precommit.yml@refs/heads/sycl (f66770956fe4000a07979a3b99773772b2980507)
2023-03-07T13:03:31.9317321Z -> intel/llvm/.github/workflows/sycl_linux_build_and_test.yml@refs/heads/sycl (f66770956fe4000a07979a3b99773772b2980507)
2023-03-07T13:03:31.9317342Z Waiting for a runner to pick up this job...
2023-03-07T13:11:10.6983891Z Job is about to start running on the runner: amdgpu-1 (repository)

@bader , can you please double-check that this is a CI issue?

No. I don't have access to this machine. Please, contact @stdale-intel to investigate this issue.

@steffenlarsen steffenlarsen temporarily deployed to aws March 7, 2023 17:41 — with GitHub Actions Inactive
@dm-vodopyanov
Copy link
Contributor

Finally, all pipeline passed successfully. However, from updated logs, this is not look like a CI issue, as such slowdown happened during tests execution:

Tue, 07 Mar 2023 13:16:37 GMT llvm-lit: /__w/llvm/llvm/src/llvm/utils/lit/lit/llvm/config.py:459: note: using ld.lld: /__w/llvm/llvm/build/bin/ld.lld
Tue, 07 Mar 2023 13:16:37 GMT llvm-lit: /__w/llvm/llvm/src/llvm/utils/lit/lit/llvm/config.py:459: note: using lld-link: /__w/llvm/llvm/build/bin/lld-link
Tue, 07 Mar 2023 13:16:37 GMT llvm-lit: /__w/llvm/llvm/src/llvm/utils/lit/lit/llvm/config.py:459: note: using ld64.lld: /__w/llvm/llvm/build/bin/ld64.lld
Tue, 07 Mar 2023 13:16:37 GMT llvm-lit: /__w/llvm/llvm/src/llvm/utils/lit/lit/llvm/config.py:459: note: using wasm-ld: /__w/llvm/llvm/build/bin/wasm-ld
Tue, 07 Mar 2023 13:16:37 GMT -- Testing: 46273 tests, 16 workers --
Tue, 07 Mar 2023 16:47:05 GMT Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Tue, 07 Mar 2023 16:47:06 GMT
Tue, 07 Mar 2023 16:47:06 GMT Testing Time: 12628.63s
Tue, 07 Mar 2023 16:47:06 GMT  Skipped          :    59
Tue, 07 Mar 2023 16:47:06 GMT  Unsupported      : 19200
Tue, 07 Mar 2023 16:47:06 GMT  Passed           : 33080
Tue, 07 Mar 2023 16:47:06 GMT  Passed With Retry:     1
Tue, 07 Mar 2023 16:47:06 GMT  Expectedly Failed:    72

Logs have strange line: Passed With Retry: 1, correct logs doesn't have such line, probably such test caused this slowdown. Unfortunately, no more information in the logs. Such slowdown looks flaky, it doesn't happen now on other pre-commits. Submitted #8563

@steffenlarsen steffenlarsen temporarily deployed to aws March 9, 2023 12:24 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants