Skip to content

[SYCL][Reduction] Limit reduction work non-uniform case #8458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

steffenlarsen
Copy link
Contributor

In certain cases non-uniform reductions will not have enough work to fill the partial reduction in the last work-group. Previously we would pad with the identity to work around this, but to avoid needing to do this we can now instead reduce the size of the partial reduction to the actual amount of work.

In certain cases non-uniform reductions will not have enough work to
fill the partial reduction in the last work-group. Previously we would
pad with the identity to work around this, but to avoid needing to do
this we can now instead reduce the size of the partial reduction to the
actual amount of work.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen temporarily deployed to aws February 24, 2023 18:09 — with GitHub Actions Inactive
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen temporarily deployed to aws February 24, 2023 19:01 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws February 24, 2023 19:34 — with GitHub Actions Inactive
aelovikov-intel and others added 3 commits March 1, 2023 13:24
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen temporarily deployed to aws March 1, 2023 14:07 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 1, 2023 16:32 — with GitHub Actions Inactive
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen temporarily deployed to aws March 2, 2023 13:51 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 2, 2023 19:03 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 4, 2023 12:24 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 6, 2023 12:44 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 6, 2023 13:48 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 6, 2023 14:47 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 6, 2023 16:23 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 7, 2023 09:18 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 7, 2023 10:16 — with GitHub Actions Inactive
@steffenlarsen
Copy link
Contributor Author

HIP Timed Out Tests (4):
SYCL :: KernelAndProgram/spec_constants_after_link.cpp
SYCL :: Regression/kernel_bundle_ignore_sycl_external.cpp
SYCL :: Regression/same_unnamed_kernels.cpp
SYCL :: Regression/static-buffer-dtor.cpp
These are currently not supported on HIP and are marked unsupported in intel/llvm-test-suite#1639.

HIP Unresolved Tests (1):
SYCL :: AsyncHandler/default_async_handler.cpp
Reported in #8555.

@steffenlarsen steffenlarsen merged commit f667709 into intel:sycl Mar 7, 2023
@dm-vodopyanov
Copy link
Contributor

@steffenlarsen
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants