-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL][Reduction] Limit reduction work non-uniform case #8458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Reduction] Limit reduction work non-uniform case #8458
Conversation
In certain cases non-uniform reductions will not have enough work to fill the partial reduction in the last work-group. Previously we would pad with the identity to work around this, but to avoid needing to do this we can now instead reduce the size of the partial reduction to the actual amount of work. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
HIP Timed Out Tests (4): HIP Unresolved Tests (1): |
Post-commit failure:
|
Fixed in #8558. |
In certain cases non-uniform reductions will not have enough work to fill the partial reduction in the last work-group. Previously we would pad with the identity to work around this, but to avoid needing to do this we can now instead reduce the size of the partial reduction to the actual amount of work.