Skip to content

[SYCL][UR] Add stubs in L0 adapter #8402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SYCL][UR] Add stubs in L0 adapter #8402

wants to merge 1 commit into from

Conversation

jandres742
Copy link
Contributor

No description provided.

@jandres742 jandres742 temporarily deployed to aws February 18, 2023 01:07 — with GitHub Actions Inactive
@bader
Copy link
Contributor

bader commented Feb 18, 2023

@jandres742, OpenCL CPU and ESIMD emulator results are impacted by infrastructure issues. I'll restart the pre-commit to get relevant results as soon as possible. No actions from your side are required. Sorry for inconvenience.

@jandres742 jandres742 temporarily deployed to aws February 18, 2023 03:05 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 19, 2023 12:24 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 21, 2023 18:35 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws February 21, 2023 19:09 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor Author

needs to be merged after #8400

@jandres742 jandres742 mentioned this pull request Feb 23, 2023
Merged
@jandres742 jandres742 force-pushed the updateur_stubs branch 2 times, most recently from ad51928 to 136ec24 Compare March 15, 2023 07:19
@jandres742 jandres742 temporarily deployed to aws March 15, 2023 07:45 — with GitHub Actions Inactive
jandres742
jandres742 commented Mar 15, 2023
View reviewed changes
sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_common.hpp
};

const int UrL0Debug = [] {
const char *DebugMode = std::getenv("UR_L0_DEBUG");
Copy link
Contributor Author

@jandres742 jandres742 Mar 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smaslov-intel : what do you think of this format? So instead of ZE_DEBUG, we would have UR_L0_DEBUG, and generally speaking, we would have UR_<ADAPTER>_<KEY>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me (but remember not to remove existing SYCL_PI_LEVEL_ZER0_* vars yet)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smaslov-intel , right, I'm not removing anything. For now, only adding UR variables

@jandres742 jandres742 temporarily deployed to aws March 15, 2023 13:51 — with GitHub Actions Inactive
@jandres742 jandres742 mentioned this pull request Mar 16, 2023
Merged
@jandres742 jandres742 changed the title Updateur stubs [SYCL][UR] Add stubs in L0 adapter Mar 24, 2023
@jandres742 jandres742 closed this Mar 24, 2023
@jandres742 jandres742 reopened this Mar 24, 2023
@jandres742 jandres742 temporarily deployed to aws March 24, 2023 21:32 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws March 24, 2023 22:06 — with GitHub Actions Inactive
@jandres742 jandres742 closed this Mar 24, 2023
@jandres742 jandres742 reopened this Mar 24, 2023
@bader
Copy link
Contributor

bader commented Mar 24, 2023

@jandres742, I don't think closing and re-opening PR will help to pass SYCL :: XPTI/kernel/basic.cpp. Are you unable to reproduce this failure locally?

@bader
Copy link
Contributor

bader commented Mar 24, 2023

@jandres742, I don't think closing and re-opening PR will help to pass SYCL :: XPTI/kernel/basic.cpp. Are you unable to reproduce this failure locally?

I see similar failures in other PR and it looks like a regression introduced by @mmoadeli in intel/llvm-test-suite@d578db9.

@jandres742
Copy link
Contributor Author

@jandres742, I don't think closing and re-opening PR will help to pass SYCL :: XPTI/kernel/basic.cpp. Are you unable to reproduce this failure locally?

I see similar failures in other PR and it looks like a regression introduced by @mmoadeli in intel/llvm-test-suite@d578db9.

Thanks @bader . The errors were with OpenCL CPU, which these changes are not affecting, which is why I thought it was infra or something unrelated to the change.

@jandres742 jandres742 temporarily deployed to aws March 24, 2023 22:36 — with GitHub Actions Inactive
@bader
Copy link
Contributor

bader commented Mar 24, 2023

The errors were with OpenCL CPU, which these changes are not affecting, which is why I thought it was infra or something unrelated to the change.

Even if so, it doesn't mean that closing/re-opening helps all infrastructure related issues. Please, apply this method only if you know what the problem was, know that it's fixed and re-running tests will give you different results. Otherwise, we just waist CI resources.

@bader
Copy link
Contributor

bader commented Mar 24, 2023

I reverted the patch causing this test to fails. Please, update your branch and make sure 01511a3 is merged. It should fix SYCL :: XPTI/kernel/basic.cpp test.

@jandres742
Copy link
Contributor Author

I reverted the patch causing this test to fails. Please, update your branch and make sure 01511a3 is merged. It should fix SYCL :: XPTI/kernel/basic.cpp test.

Thanks @bader for the guideline and help. Will do so.

@jandres742 jandres742 temporarily deployed to aws March 24, 2023 23:08 — with GitHub Actions Inactive
[SYCL][UR] Add stubs in L0 adapter
e1af2f1 
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
@jandres742 jandres742 temporarily deployed to aws March 25, 2023 01:05 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws March 25, 2023 02:00 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor Author

jandres742 commented Mar 25, 2023 •
edited
Loading

@smaslov-intel, @bmyates: ready for review.

@jandres742 jandres742 marked this pull request as ready for review March 25, 2023 03:48
@jandres742 jandres742 requested a review from a team as a code owner March 25, 2023 03:48
@jandres742 jandres742 closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaslov-intel smaslov-intel smaslov-intel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jandres742 @bader @smaslov-intel