[SYCL][UR] Add UR bindings #8400
Conversation
|
@jandres742, I restarted pre-commit checks. OpenCL CPU results were invalid due to infrastructure issue. Sorry for inconvenience. NOTE: failure on GPU seems to be related to the change though. |
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742
force-pushed
the
updateur_bindings
branch
from
942c9e5 to
83c9115
Compare
|
Rebased. |
|
@smaslov-intel please review. |
| @@ -0,0 +1,52 @@ | |||
| //===--------- ur_level_zero.hpp - Level Zero Adapter -----------------===// | |||
There was a problem hiding this comment.
I will update these headers for all files with the each file's name.
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
| #include <cassert> | ||
| #include <list> | ||
| #include <map> | ||
| #include <stdarg.h> |
There was a problem hiding this comment.
nit: do we need all those includes (e.g. stdarg.h)? Probably some of the could be moved to .cpp file or even removed?
There was a problem hiding this comment.
thanks @igchor . Not actually needed at the moment, I can remove them and then add them as needed.
| @@ -0,0 +1,15 @@ | |||
| //===--------- ur_level_zero_native.cpp - Level Zero Adapter ----------===// | |||
There was a problem hiding this comment.
What will "native" be for?
There was a problem hiding this comment.
not sure at the moment. in the local development I have been doing I haven't used this file actually. I can remove it and add it later if needed.
@igchor : addressed comments. Please check. |
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
|
@intel/llvm-reviewers-runtime : please review/approve/merge this |
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
No description provided.